W3C home > Mailing lists > Public > public-qa-dev@w3.org > October 2002

Fwd: validator/httpd/cgi-bin check

From: Martin Duerst <duerst@w3.org>
Date: Wed, 09 Oct 2002 13:05:54 +0900
Message-Id: <4.2.0.58.J.20021009121707.054cafc8@localhost>
To: public-qa-dev@w3.org

Hello Ville,

Just to make sure that I understand what's going on:

my original version was:
    return $encodingA && $encodingB && $encodingA ne $encodingB;
your first version was:
    return $encodingA && $encodingB and $encodingA ne $encodingB;
your current version is:
    return (($encodingA && $encodingB) and ($encodingA ne $encodingB));

I think that my original version was correct, yes?
I don't understand why you want to make a difference between
the first logical 'and' and the second logical 'and', both
are equivalent.

I would therefore prefer to either return to the original version,
or to write it as:
    return ($encodingA and $encodingB and $encodingA ne $encodingB);
or maybe
    return ($encodingA and $encodingB and ($encodingA ne $encodingB));
or
    return $encodingA && $encodingB && ($encodingA ne $encodingB);
to make the structure clearer.

Please change it to your preferred version.

Please note that I may change this again; I'm thinking about
distinguishing 'undef' and empty string, to catch cases such
as <?xml version='1.0' encoding=''?>

Regards,    Martin.


>Date: Sat, 5 Oct 2002 07:21:09 -0400
>From: "DEV user - Ville Skytta - contact ot - ville.skytta@iki.fi - ville" 
><ville@abyss.w3.org>
>To: www-validator-cvs@w3.org
>Subject: validator/httpd/cgi-bin check

>Modified Files:
>         check
>Log Message:
>Fixed an operator precedence bug in charset conflict detection.
>It's again possible to validate pages that properly define UTF-8 in the HTTP
>headers, like the validator itself.
>VS: ----------------------------------------------------------------------
Received on Wednesday, 9 October 2002 00:59:21 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Thursday, 19 August 2010 18:12:43 GMT