W3C home > Mailing lists > Public > public-html-testsuite@w3.org > October 2012

Re: InvalidStateError and TextTrackCue.snapToLines

From: Ms2ger <ms2ger@gmail.com>
Date: Sun, 21 Oct 2012 16:45:43 +0200
Message-ID: <50840A97.5080208@gmail.com>
To: Philippe Le Hegaret <plh@w3.org>
CC: Simon Pieters <simonp@opera.com>, "public-html-testsuite@w3.org" <public-html-testsuite@w3.org>
On 10/21/2012 04:25 PM, Philippe Le Hegaret wrote:
> Hi Simon,
>
> I have two questions regarding your new submission:
>
> 1. You're using INVALID_STATE_ERR for assert_throws. Shouldn't you use
> "new InvalidStateError()" instead? After all, you're using new TypeError
> in other places...

No. It should be either the string "INVALID_STATE_ERR" or the string 
"InvalidStateError" for DOMExceptions; JS-native exceptions like 
TypeError use a "new TypeError()" object.

See <http://dvcs.w3.org/hg/resources/file/b7d2c317fdca/testharness.js#l298>.

HTH
Ms2ger
Received on Sunday, 21 October 2012 14:46:13 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Sunday, 21 October 2012 14:46:13 GMT