W3C home > Mailing lists > Public > public-grddl-wg@w3.org > April 2007

Re: review of test cases

From: Jeremy Carroll <jjc@hpl.hp.com>
Date: Mon, 30 Apr 2007 14:50:18 +0100
Message-ID: <4635F41A.4080707@hpl.hp.com>
To: ogbujic@ccf.org
CC: GRDDL Working Group <public-grddl-wg@w3.org>


I am happy with these modifications, except:
- the aboutTests change,
- inclusion of base-detail, superceded by events
- minor aspects of description of #xmlbase3

Also, no approval seems to have been added to the grddl result for 
embedded-rdf4.


aboutTests
==========

I'll explain my concerns, and make a suggestion as to achieve both our 
goals.

My understanding is that a URI such as

http://www.w3.org/TR/grddl-tests/titleauthor.html

are not part of the WG's intent.

The GRDDL result of the test cases document, when published at

http://www.w3.org/TR/grddl-tests/

will include such a URI; hence this is unsatisfactory.
I also believe that the GRDDL results will be published at
http://www.w3.org/TR/grddl-tests/grddl-tests.rdf
and once again, this should not include relative URIs into 
http://www.w3.org/TR/grddl-tests/

If
http://www.w3.org/2001/sw/grddl-wg/td/grddl-tests.rdf
is copied as is into the TR directory, we will have such references to 
non-resources.

It would be possible to do either of the following:

a) use the aboutTests as modified, but with an 
xml:base="http://www.w3.org/2001/sw/grddl-wg/td/"
and then someone wanting to do local testing, can simply delete that base.

b) include the aboutTests as modified as aboutTestsLocal.xsl, and revert 
aboutTests.xsl to only give the full URLs

Personally, I think either of these is unnecessary, but I wouldn't mind.

For me, the implementor who is testing against a local copy of the test 
material is using a cache, and that is their responsibility and not the 
WGs. (a) above, in particular, seems to be making enough allowance for 
such an implementor


Suggested change:

<xsl:template match="/">
   <r:RDF>
     <xsl:apply-templates />
   </r:RDF>
</xsl:template>

to

<xsl:template match="/">
   <r:RDF xml:base="http://www.w3.org/2001/sw/grddl-wg/td/">
   <xsl:comment>If you wish to run the tests using local copies of the 
files then it is possible to modify the above xml:base as 
appropriate.</xsl:comment>
     <xsl:apply-templates />
   </r:RDF>
</xsl:template>


#xmlbase3
=========
The current text makes the incorrect statement:
[[
The base URI of the document is the target URI of the last redirection step
]]
I suggest the following change
Replace:
[[
The base URI of the document is the target URI of the last redirection 
step; after establishing this fact, this test case follows the same 
behavior as "An xml document with an xml:base attribute".
]]
with:
[[
The base URI of the document is established by the xml:base on the root 
element, as for "An xml document with an xml:base attribute".
]]

base-detail
===========

The text is:
[[
# A transform that does not respect xml:base:
input output

The output of a transform is processed with the retrieval IRI, not that 
given by an xml:base.
]]
This text is not consistent with the descriptions and decisions of the 
xmlbase and htmlbase tests.

Since we have not approved this test, I suggest simply deleting it.
We may want to review our coverage of the base issues later.

mechanical review
=================

I've run my code, against the new editor's draft (with no modifications 
being applied)

The results are:
#base-detail
#embedded-rdf4
these two are not listed as approved.

I got a failure on #base-detail :(
On examination this appears to be a bug in my code - but I haven't 
worked out quite what.



Jeremy




Chimezie Ogbuji wrote:
> The test case document has been updated:
> 
> RCS file: /w3ccvs/WWW/2001/sw/grddl-wg/td/grddl-tests.html,v
> ----------------------------
> revision 1.27
> date: 2007/04/27 15:01:34;  author: cogbuji;  state: Exp;  lines: +210
> -232
> - changed all test input/output to absolute URIs
> - updated approval indications
> - removed tests per WG decision (httpHeaders and primer-hotel-data)
> - added base-detail
> ----------------------------
> 
> 
> On Wed, 2007-04-25 at 11:51 +0100, Jeremy Carroll wrote:
>> critical
>> ========
>>
>> A)
>> all input and output documents should be specified with absolute URIs.
> 
> This has been changed in grddl-tests.html.  However, in order to support
> the ability to run tests locally, I've modified aboutTests.xsl to reduce
> the input/output references for localized tests back to their relative
> form in the manifest.
> 
> RCS file: /w3ccvs/WWW/2001/sw/grddl-wg/td/aboutTests.xsl,v
> ----------------------------
> revision 1.17
> date: 2007/04/27 14:58:52;  author: cogbuji;  state: Exp;  lines: +13 -7
> - strips out leading "http://www.w3.org/2001/sw/grddl-wg/td/" from
> input/output URIs so it can resolve them against different bases as
> before
> ----------------------------
> 
> 
> 
>> B)
>> output documents for #xmlbase[1234] should be modified as previously 
>> indicated
> 
> 
>> C)
>> test #primer-hotel-data should be removed.
> 
> Done..
> 
>> D)
>> test #httpHeaders either
>> - it should be removed
>> or
>> - the text should be something like
>> [[
>> Test the use of http headers to define a transform,
>> anticipating an RFC HTTP Header Linking, based on the expired
>> draft-nottingham-http-link-header-00
>> ]]
> 
> This test was removed
> 
>>
>> non-critical
>> ============
>> spelling of ambiguous, through-out.
> 
> Changed..
> 
>> The following need not be network tests
>> #html-and-transformation-attr
> 
> This test (as well as all the htmlbase*/xmlbase* tests) depends on
> server side redirection.  For example, the relative input URI for this
> (approved) test is:  html-and-grddl-xform-attr which requires a redirect
> to html-and-grddl-xform-attr.html.  So, to make it a local test it would
> have required changing the inputs and I didn't feel comfortable doing so
> with tests that have already been approved.  
> 
>> #xhtmlWithGrddlEnabledProfileAndInBodyTransform
>> #xhtmlWithGrddlEnabledProfileAndADisabledInBodyTransform
> 
> These already have 'complete' URLs and the indication that they are
> networked tests have been removed
> 
>> #htmlbase1
>> #htmlbase2
>> #xmlbase1
>> #xmlbase2
> 
> See above..
> 
>> Adding
>> http://www.w3.org/2001/sw/grddl-wg/td/pendinglist.html#base-detail
> 
> This has been added and is the only test with outstanding approval.
> Note: GRDDLpy currently passes this test - I'll be sending an updated
> earl report soon. 
> 

-- 
Hewlett-Packard Limited
registered Office: Cain Road, Bracknell, Berks RG12 1HN
Registered No: 690597 England
Received on Monday, 30 April 2007 14:28:48 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Tuesday, 8 January 2008 14:11:49 GMT