W3C home > Mailing lists > Public > public-device-apis-log@w3.org > May 2019

Re: [wake-lock] Do not assign a default value to WakeLockRequestOptions.signal (#203)

From: Marcos Cáceres via GitHub <sysbot+gh@w3.org>
Date: Mon, 06 May 2019 02:55:00 +0000
To: public-device-apis-log@w3.org
Message-ID: <issue_comment.created-489488446-1557111299-sysbot+gh@w3.org>
> Setting a default value to the nullable member signal means we'd always
have a signal member in the dictionary even when we do not set it at
all (first 2 cases), which is not needed and does not make sense.

Agree. The problem was (is?) that the algorithm prose was defaulting it to `null`. If the prose doesn't does that anymore, then I'm ok with this. 

However, I'd still like clarity on what happens when `null` is set. Why have nullable at all?  


-- 
GitHub Notification of comment by marcoscaceres
Please view or discuss this issue at https://github.com/w3c/wake-lock/pull/203#issuecomment-489488446 using your GitHub account
Received on Monday, 6 May 2019 02:55:02 UTC

This archive was generated by hypermail 2.3.1 : Monday, 6 May 2019 02:55:03 UTC