W3C home > Mailing lists > Public > public-device-apis-log@w3.org > May 2019

Re: [wake-lock] Do not assign a default value to WakeLockRequestOptions.signal (#203)

From: Raphael Kubo da Costa via GitHub <sysbot+gh@w3.org>
Date: Mon, 06 May 2019 09:18:04 +0000
To: public-device-apis-log@w3.org
Message-ID: <issue_comment.created-489558066-1557134281-sysbot+gh@w3.org>
> However, I'd still like clarity on what happens when `null` is set. Why have nullable at all?

You have a point, I don't think this needs to be nullable at all. Most other occurrences of `AbortSignal` in a dictionary aren't nullable either, module Fetch's `RequestInit.signal`, and only because one can [pass a `Request` to another `Request`'s constructor](https://github.com/whatwg/fetch/pull/523#discussion_r138897886).

I'll send a new PR making `signal` a regular member.

-- 
GitHub Notification of comment by rakuco
Please view or discuss this issue at https://github.com/w3c/wake-lock/pull/203#issuecomment-489558066 using your GitHub account
Received on Monday, 6 May 2019 09:18:09 UTC

This archive was generated by hypermail 2.3.1 : Monday, 6 May 2019 09:18:09 UTC