W3C home > Mailing lists > Public > public-css-testsuite@w3.org > April 2017

Re: nav-down-012 test issue

From: Florian Rivoal <florian@rivoal.net>
Date: Wed, 5 Apr 2017 21:29:16 +0900
Cc: "public-css-testsuite@w3.org" <public-css-testsuite@w3.org>
Message-Id: <37FDB075-8142-4009-9717-2DE071A899DA@rivoal.net>
To: Dawid Błachut <d.blachut@adbglobal.com>
Posting answers inline.
> On Apr 5, 2017, at 19:47, Dawid Błachut <d.blachut@adbglobal.com> wrote:
> Dear Florian,
> thank you for your answer, I did not know about the github repository.
> There is another issue in this test, inside css/css-ui-3/support/nav-up-012-frame.html. '<target-name>' <https://www.w3.org/TR/css-ui-3/#typedef-target-name> should be a <string> <https://www.w3.org/TR/css3-values/#string-value>, so it would need to be enveloped with double quotes or single quotes.
> Unless the test checks how browser handle such situation, but it is not clear form the description that it should test that behavior ('Assertion:' field).
You are right. I added this to the review-pending fix made earlier. https://github.com/w3c/web-platform-tests/pull/5377
> I have another overall comment on the directional navigation tests. In my opinion it would be great to add some css rule that make the focused elements more visible (e.g. change the background), since this is not clear which one is currently focused while testing.
> :focus {
>     background-color: yellow;
> }

On the browser I tested with (opera), it is quite clear thanks to the browser's focus indicators which element is selected. Are you having issues because the browser(s) you are using do not provide good focus indicators by default?

If that's the case, I can see how adding something like what you suggested would help.
> If you want I can submit this as two separate issues in github.
For the first one, no need to, I've already handled it.

For the second case, the best would be if you could submit a Pull Request proposing these changes. Then I would be able to review it and get it merged soon.

If you are not familiar with Git/Github/pull requests, we can do otherwise, but that would be ideal

Best regards,
Received on Wednesday, 5 April 2017 12:29:47 UTC

This archive was generated by hypermail 2.3.1 : Wednesday, 5 April 2017 12:29:49 UTC