W3C home > Mailing lists > Public > public-css-testsuite@w3.org > September 2015

Re: [CSS21][CSS22] Seeking review of position:fixed edge case test

From: Chris Rebert <csswg@rebertia.com>
Date: Sat, 12 Sep 2015 21:30:39 -0700
Message-ID: <CAMZYqRR_9UuBYMA2AQp=J6rt0C-FaqZaQb3wiVkKaGSHUa84LA@mail.gmail.com>
To: Gérard Talbot <css21testsuite@gtalbot.org>
Cc: Public CSS Test suite mailing list <public-css-testsuite@w3.org>
On Mon, Aug 17, 2015 at 1:49 PM, Gérard Talbot
<css21testsuite@gtalbot.org> wrote:
> Le 2015-08-17 15:08, Chris Rebert a écrit :
>> On Tue, Aug 4, 2015 at 9:06 PM, Gérard Talbot
>> <css21testsuite@gtalbot.org> wrote:
>>> Le 2015-07-27 03:21, Chris Rebert a écrit :
>>>>
>>>> Hi folks,
>>>>
>>>> I'm trying to get a reviewer for a CSS2 regression test:
>>>> https://github.com/w3c/csswg-test/pull/813
>> <snip>
>>> Your test is a good test. Indeed iPhone 6, Safari 7+ fail your test. Here's
>>> some review comments.
<snip>
>>> 7-
>>> p {
>>>   position: absolute;
>>>   top: 100px;
>>> }
>>>
>>> It is recommended to start all tests with the pass-fail-conditions sentence
>>> and, since it should not be part of the test itself, then we do not want to
>>> style it in any way. Sometimes, this is not possible but, I'd say 99% of the
>>> time, it is possible.
>>
>> The position:fixed makes doing this somewhat tricky.
>> If you have a specific suggestion for how to achieve this, I'm fine
>> with changing the test, but I myself don't have any ideas.
>
> The modified test I created made that possible.

Revised.

>>> Here's what could be your test with all these changes:
>>>
>>> http://www.gtalbot.org/BrowserBugsSection/css21testsuite/left-offset-position-fixed-001.xht
<snip>
>>> One last thing. One other equivalent test could be created with 'direction:
>>> rtl', 'position fixed', 'right: auto' for many reasons. Also, same 2 tests
>>> but with 'position: absolute'. So, 3 other additional tests with the same
>>> basis code are possible here.
>>
>> I'm not familiar enough with `direction`/RTL to write those variants,
>
> http://www.gtalbot.org/BrowserBugsSection/css21testsuite/right-offset-position-fixed-001.xht
>
> iPhone 6, Safari 7+ fail this additional test.
> The text assert and a few other things in that right-offset-position-fixed-001 would need to be adjusted, tweaked.

Added the RTL and position:absolute tests you suggested.

Everything look good now?:
https://github.com/w3c/csswg-test/pull/813/files

Thanks,
Chris
--
Bootstrap Core Team member
Browser 🐛 of the day: http://bugzil.la/1203844
Received on Sunday, 13 September 2015 04:31:07 UTC

This archive was generated by hypermail 2.3.1 : Sunday, 13 September 2015 04:31:11 UTC