Re: [css-writing-modes-3] Additional review of vertical-alignment-new-00? tests

Gérard,

are you sure it was okay to remove *all* those 32 tests? I wonder if a few
> just needed to be adjusted. I know there were some tests with
> 'text-orientation: sideways-right' and
> 'text-orientation: upright' ... Are you planning to re-create some tests
> with 'text-orientation: sideways-right' and 'text-orientation: upright' and
> vertical-align ?
>

Yes, I'm planning to recreate tests with vertical-align property 'super',
'middle' and 'sub'.
I'm planning to consider these tests in this weekend.
And I want to create and submit the first version of these tests.

In
>
>
> http://test.csswg.org/source/css-writing-modes-3/vertical-alignment-008-ref.xht
>
> line 8:
>     img
>     {
>       vertical-align: top;
>     }
>
>     img#orange
>     {
>       padding-top: 30px; /* = the height of first character */
>       padding-left: 30px;
>     }
>
> can be completely replaced with only (more concise)
>
>     img#orange
>     {
>       padding-left: 30px;
>     }
>
>
> - - - - - - - - - - - -
>
>
> Please add
>
> <link rel="reviewer" title="Gérard Talbot" href="
> http://www.gtalbot.org/BrowserBugsSection/css21testsuite/" /> <!--
> 2015-09-03 -->
>
> to all
>
>
> http://test.csswg.org/source/css-writing-modes-3/vertical-alignment-00[2-9].xht
> tests and to their related reference files.


Thank you, done!
https://hg.csswg.org/test/rev/db9eef92e10d

Hajime.

-- 
# 塩澤 元 (Shiozawa, Hajime)
# mail: hajime.shiozawa@gmail.com

Received on Thursday, 3 September 2015 14:50:43 UTC