W3C home > Mailing lists > Public > public-css-testsuite@w3.org > February 2013

Re: CSS3 writing-modes inline-alignment test suites

From: Shiozawa, Hajime <hajime.shiozawa@gmail.com>
Date: Sun, 17 Feb 2013 13:50:23 +0900
Message-ID: <CAHSwuKOx7NZZ+4uZr+2XYZu7gXew+_EeTC2T-=rb_CLOzJ2jaQ@mail.gmail.com>
To: "Grard Talbot" <css21testsuite@gtalbot.org>, Public CSS test suite mailing list <public-css-testsuite@w3.org>
Hi, Grard

I have applied your comments to tests and re-submitted to repository.
http://test.csswg.org/shepherd/search/testcase/spec/css3-writing-modes/status/submitted/

> Also I wonder why you did not filenamed them as
> text-baseline-001, 002, 003 in the beginning. Maybe inline-alignment is
> better... I do not know... but my first thought was that maybe
> text-baseline-xxx would be best as filename.
OK. I change file name to 'text-baseline-xxx.xht'.

I used the word 'inline-alignment' because it is used as a section
name '4 Inline-level Alignment' on writing-modes specification [1].
But now I think 'text-baseline' is better name because the test case
which I re-submitted tests only text's baseline.
(I think that another test case which tests alignment with
inline-block is about 'inline-block-baseline.xht')

> 5.
> line 6: <link rel="help" title="CSS3 Writing modes: 4.2. Text Baseline"
> href="http://www.w3.org/TR/css3-writing-modes/#text-baselines" />
>
> Just
>
> <link rel="help" title="4.2. Text Baseline"  href="http://www.w3.org/TR/css3-writing-modes/#text-baselines" />
>
> is okay.
OK. I removed 'CSS3 Writing Modes: ' from specification link.

> 6.
> line 7:
> <meta name="assert" content="This tests a basic inline text alignment.
> Check that an alphabetical baseline is used as the dominant baseline." />
>
> I suggest for your consideration
>
> <meta name="assert" content="This test checks the generation of text
> baseline. Unless 'writing-mode' is vertical and also unless
> 'text-orientation' is 'mixed' or 'upright', the alphabetical baseline is
> used as the dominant baseline." />
OK. I applied it to test assertion sentence.

> 7.
> line 50: <p>Test passes if the bottom of glyph 'L' and the blue line are
> aligned.</p>
>
> In the past, when tests were mentioning align or alignment, we often had
> to specify if it was an horizontal alignment or a vertical alignment for
> clarity. Here, I would consider stating:
>
> <p>Test passes if the bottom of glyph 'L' is touching a thin blue line
> in each 6 orange rectangles.</p>
OK. I applied it to assertion phrase.

> Another idea would be to create a reference as a 7th object in your test
> and then state
>
> <p>Test passes if each 7 orange rectangles are
> <strong>identical</strong>.</p>
>
> line 44: <p>Test passes if each 7 orange rectangles are
> <strong>identical</strong>.</p>
>
> line 44.5: <p id="control">LLLLLLLLLLLL<img src="./support/baseline.png"
> alt="Image download support must be enabled" width="220" height="1"
> /></p>
>
> line 45: <div class="horizontal-tb">
>
> You can then later reuse that reference to create a reftest (for
> automated checking) for this test.
OK. I created the new ref file 'text-baseline-001-ref.xht'

Now I consider about ref test for text-baseline-00{2, 3}.xht.
The following code is prototype.

== TEST ==
<p>Test passes if each 5 orange rectangles are <strong>identical</strong>.</p>
<div class="vertical-rl">
  <p id='reference' class="sideways-right">LLLLLLLLLLLL<img
src="./support/blue-vert-line_1x220.png" alt="Image download support
must be enabled" /></p>
  <p class="sideways-right">LLLLLLLLLLLL<img
src="./support/blue-vert-line_1x220.png" alt="Image download support
must be enabled" /></p>
  <p class="sideways-left">LLLLLLLLLLLL<img
src="./support/blue-vert-line_1x220.png" alt="Image download support
must be enabled" /></p>
  <p class="sideways">LLLLLLLLLLLL<img
src="./support/blue-vert-line_1x220.png" alt="Image download support
must be enabled" /></p>
  <p class="use-glyph-orientation">LLLLLLLLLLLL<img
src="./support/blue-vert-line_1x220.png" alt="Image download support
must be enabled" /></p>
</div>

== REF ==
<p>Test passes if each 5 orange rectangles are <strong>identical</strong>.</p>
<div class='vertical-rl'>
  <p class="sideways-right">LLLLLLLLLLLL<img
src="./support/blue-vert-line_1x220.png" alt="Image download support
must be enabled" /></p>
  <p class="sideways-right">LLLLLLLLLLLL<img
src="./support/blue-vert-line_1x220.png" alt="Image download support
must be enabled" /></p>
  <p class="sideways-right">LLLLLLLLLLLL<img
src="./support/blue-vert-line_1x220.png" alt="Image download support
must be enabled" /></p>
  <p class="sideways-right">LLLLLLLLLLLL<img
src="./support/blue-vert-line_1x220.png" alt="Image download support
must be enabled" /></p>
  <p class="sideways-right">LLLLLLLLLLLL<img
src="./support/blue-vert-line_1x220.png" alt="Image download support
must be enabled" /></p>
</div>

But I think that this test is only meaningful if 'sideways-right'
property is already implemented correctly.
Do you think this code makes sense?
Also could you give me advice for these ref test?

> 8.
> alt="baseline"
>
> We want the tester to press the fail button if the image does not load.
> So, in all tests, we usually specify the alt attribute with:
>
> alt="Image download support must be enabled"
>
> which would warn the tester to check if he/she has disabled the image
> download support of his/her browser.
OK. I changed the alt attributes sentence.

> 9.
> One idea would be to create an 220px wide and 1px tall blue image and
> then just use
> <img src="support/blue-horiz-line-220x1.png" alt="Image download support
> must be enabled" />
>
> That way, you do not need to specify the width and height and the test
> is fully convertible to HTML5.
OK. I added two image file (blue-horiz-line-220x1.png and
blue-vert-line-1x220.png)
to display a baseline, and removed width and height attributes from img tag.

-- 
#   (Shiozawa, Hajime)
# mail: hajime.shiozawa@gmail.com
Received on Sunday, 17 February 2013 04:50:53 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Sunday, 17 February 2013 04:50:56 GMT