W3C home > Mailing lists > Public > public-css-testsuite@w3.org > February 2013

Re: CSS3 writing-modes inline-alignment test suites

From: Gérard Talbot <css21testsuite@gtalbot.org>
Date: Mon, 11 Feb 2013 17:24:53 -0500
Message-ID: <2d687bdf86f5692ef5ba46189453d387.squirrel@ed-sh-cp3.entirelydigital.com>
To: "塩澤 元 (Shiozawa, Hajime)" <hajime.shiozawa@gmail.com>
Cc: "Public CSS test suite mailing list" <public-css-testsuite@w3.org>

Le Lun 11 février 2013 6:13, 塩澤 å…ƒ (Shiozawa, Hajime) a écrit :
> Gérard, thank you for comment.
>
> I have fixed my tests and re-submitted a most simple test case
> (inline-alignment-001.xht)
> http://test.csswg.org/shepherd/search/testcase/spec/css3-writing-modes/status/submitted/
>
> [Changes]
>   1. divide inline-alignment-001.xht to three files.


http://test.csswg.org/source/contributors/hshiozawa/submitted/css3-writing-modes/


Hajime,

I believe you should rename these tests like this:

inline-alignment-001a as 001,
inline-alignment-001b as 002,
inline-alignment-001c as 003.

Also I wonder why you did not filenamed them as
text-baseline-001, 002, 003 in the beginning. Maybe inline-alignment is
better... I do not know... but my first thought was that maybe
text-baseline-xxx would be best as filename.


>   2. change the title to contain the module name (CSS Writing Modes)
> before ":"
>   3. use orange as background-color and blue as baseline color insted
> of use green.
>   4. draw the base line position as blue line referring to your test
> case [1].

5.
line 6: <link rel="help" title="CSS3 Writing modes: 4.2. Text Baseline"
href="http://www.w3.org/TR/css3-writing-modes/#text-baselines" />

Just

<link rel="help" title="4.2. Text Baseline"
href="http://www.w3.org/TR/css3-writing-modes/#text-baselines" />

is okay.

6.
line 7:
<meta name="assert" content="This tests a basic inline text alignment.
Check that an alphabetical baseline is used as the dominant baseline."
/>

I suggest for your consideration

<meta name="assert" content="This test checks the generation of text
baseline. Unless 'writing-mode' is vertical and also unless
'text-orientation' is 'mixed' or 'upright', the alphabetical baseline is
used as the dominant baseline." />



7.
line 50: <p>Test passes if the bottom of glyph 'L' and the blue line are
aligned.</p>

In the past, when tests were mentioning align or alignment, we often had
to specify if it was an horizontal alignment or a vertical alignment for
clarity. Here, I would consider stating:

<p>Test passes if the bottom of glyph 'L' is touching a thin blue line
in each 6 orange rectangles.</p>

or

<p>Test passes if the bottom of glyph 'L' is sitting on a thin blue line
in each 6 orange rectangles.</p>

Another idea would be to create a reference as a 7th object in your test
and then state

<p>Test passes if each 7 orange rectangles are
<strong>identical</strong>.</p>

line 44: <p>Test passes if each 7 orange rectangles are
<strong>identical</strong>.</p>

line 44.5: <p id="control">LLLLLLLLLLLL<img src="./support/baseline.png"
alt="Image download support must be enabled" width="220" height="1"
/></p>

line 45: <div class="horizontal-tb">

You can then later reuse that reference to create a reftest (for
automated checking) for this test.

8.
alt="baseline"

We want the tester to press the fail button if the image does not load.
So, in all tests, we usually specify the alt attribute with:

alt="Image download support must be enabled"

which would warn the tester to check if he/she has disabled the image
download support of his/her browser.

9.
width="220px" height="1px"
height and width attribute are usually without units


By the way, in HTML5:
"
The width and height attributes on img (...) are also not allowed to be
used to stretch the image to a different aspect ratio than its intrinsic
aspect ratio.
"
HTML5 differences from HTML4
3.4 Changed Attributes
http://dev.w3.org/html5/html4-differences/#changed-attributes

You used XHTML1 which allows stretching the image to different aspect
ratio.

One idea would be to create an 220px wide and 1px tall blue image and
then just use
<img src="support/blue-horiz-line-220x1.png" alt="Image download support
must be enabled" />

That way, you do not need to specify the width and height and the test
is fully convertible to HTML5.

10.

Your

http://test.csswg.org/source/contributors/hshiozawa/submitted/css3-writing-modes/inline-alignment-001a.xht

could or would become (with all the changes above approved by you)
something like:

http://www.gtalbot.org/BrowserBugsSection/review/text-baseline-001-review.xht

(I have removed 2 "L" and moved the blue line to the left of 10
additional pixels.)

and its reftest is:

http://www.gtalbot.org/BrowserBugsSection/review/text-baseline-001-ref-review.xht


Gérard

>
> I would like to re-submit other tests after this simple test case
> passes your review.
>
> [1]: http://www.gtalbot.org/DHTMLSection/vertical-align-values.html
>
> --
> # 塩澤 元 (Shiozawa, Hajime)
> # mail: hajime.shiozawa@gmail.com
>
>


-- 
Contributions to the CSS 2.1 test suite:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/

CSS 2.1 Test suite RC6, March 23rd 2011:
http://test.csswg.org/suites/css2.1/20110323/html4/toc.html

CSS 2.1 test suite harness:
http://test.csswg.org/harness/

Contributing to to CSS 2.1 test suite:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/web-authors-contributions-css21-testsuite.html
Received on Monday, 11 February 2013 22:25:44 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Monday, 11 February 2013 22:25:48 GMT