W3C home > Mailing lists > Public > public-css-testsuite@w3.org > February 2013

Re: CSS3-text-decoration: text-decoration-line

From: Gérard Talbot <css21testsuite@gtalbot.org>
Date: Thu, 14 Feb 2013 17:56:59 -0500
Message-ID: <6e19f1dfa35dc8fd8469aad30586e9d3.squirrel@ed-sh-cp3.entirelydigital.com>
To: "taka" <takaoshiyama@gmail.com>
Cc: public-css-testsuite@w3.org
Le Mar 12 février 2013 22:00, taka a écrit :
> Please review a series of the subject test cases as I submitted to
Shepherd below:
> http://test.csswg.org/shepherd/search/spec/css-text-decor-3/author/taka/load/t48/#t16
thanks in advance and regards,


Taka,

http://test.csswg.org/source/contributors/east-tokyo/submitted/css3-text/text-decoration-line-010.xht



line 5: <title>CSS Text Test: text-decoration-line</title>

"
For specifications other than CSS 2.1, you can include the module name
somewhere before the colon, like “CSS Selectors Test:” or “CSS Test
(Selectors):”. Do not include the module version number, since the test
might get reused for the next version.
"

So here,

<title>CSS Text Decoration Test: text-decoration-line - none</title>

is adequate.

----------

line 12: <meta name="assert" content="Neither produces nor inhibits text
decoration." />

I suggest
<meta name="assert" content="This test checks that
'text-decoration-line: none' does not produce any text decoration." />

I have asked why the spec mentions "nor inhibits text decoration" part:
[CSS3] [text-decor] text-decoration-line: none
http://lists.w3.org/Archives/Public/www-style/2013Feb/0359.html

The "nor inhibits text decoration" part would require an ancestor box
with text-decoration declaration in your test.

Eg.

http://www.gtalbot.org/BrowserBugsSection/CSS3TextDecoration/text-decoration-line-456.xht

http://www.gtalbot.org/BrowserBugsSection/CSS3TextDecoration/text-decoration-line-459.xht

----------


line 14 to 23: as it is, downloading and processing a @font-face 8MB
font is inappropriate; mplus-1p-regular font (1.3MB) is better but still
not satisfactory. I have no complete solution ready and tested to
propose right now.


----------

line 41:
<p>Test passes if no line is displayed.</p>

This can confuse testers: line can mean an horizontal rule or it can
mean a line of text. I propose

<p>Test passes if the 2 "Text sample
&#12469;&#12531;&#12503;&#12523;&#25991;" are underlined and
<strong>identical</strong>.</p>

You can reuse such kind of pass/fail conditions sentence, formulation in
all your tests.

Gérard
-- 
Contributions to the CSS 2.1 test suite:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/

CSS 2.1 Test suite RC6, March 23rd 2011:
http://test.csswg.org/suites/css2.1/20110323/html4/toc.html

CSS 2.1 test suite harness:
http://test.csswg.org/harness/

Contributing to to CSS 2.1 test suite:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/web-authors-contributions-css21-testsuite.html
Received on Thursday, 14 February 2013 22:57:34 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Thursday, 14 February 2013 22:57:37 GMT