W3C home > Mailing lists > Public > public-css-testsuite@w3.org > September 2012

Creating reftests for your dynamic-top-change-* tests; your first-letter-quote-00* tests and reftests

From: Gérard Talbot <css21testsuite@gtalbot.org>
Date: Mon, 17 Sep 2012 21:44:27 -0400
Message-ID: <4059b557e983a0668cea5a50dc7a38e2.squirrel@ed-sh-cp3.entirelydigital.com>
To: "Boris Zbarsky" <bzbarsky@MIT.EDU>
Cc: "Public CSS testsuite mailing list" <public-css-testsuite@w3.org>
Boris,

[RC6]
http://test.csswg.org/suites/css2.1/20110323/html4/dynamic-top-change-001.htm

[nightly-unstable]
http://test.csswg.org/suites/css2.1/nightly-unstable/html4/dynamic-top-change-001.htm

[src]
http://test.csswg.org/source/approved/css2.1/src/positioning/dynamic-top-change-001.xht

[reftest]
http://test.csswg.org/source/approved/css2.1/src/positioning/dynamic-top-change-001-ref.xht



[RC6]
http://test.csswg.org/suites/css2.1/20110323/html4/dynamic-top-change-002.htm

[nightly-unstable]
http://test.csswg.org/suites/css2.1/nightly-unstable/html4/dynamic-top-change-002.htm

[src]
http://test.csswg.org/source/approved/css2.1/src/positioning/dynamic-top-change-002.xht

[reftest]
http://test.csswg.org/source/approved/css2.1/src/positioning/dynamic-top-change-002-ref.xht



[RC6]
http://test.csswg.org/suites/css2.1/20110323/html4/dynamic-top-change-003.htm

[nightly-unstable]
http://test.csswg.org/suites/css2.1/nightly-unstable/html4/dynamic-top-change-003.htm

[src]
http://test.csswg.org/source/approved/css2.1/src/positioning/dynamic-top-change-003.xht

[reftest]
http://test.csswg.org/source/approved/css2.1/src/positioning/dynamic-top-change-002-ref.xht



[RC6]
http://test.csswg.org/suites/css2.1/20110323/html4/dynamic-top-change-004.htm

[nightly-unstable]
http://test.csswg.org/suites/css2.1/nightly-unstable/html4/dynamic-top-change-004.htm

[src]
http://test.csswg.org/source/approved/css2.1/src/positioning/dynamic-top-change-004.xht

[reftest]
http://test.csswg.org/source/approved/css2.1/src/positioning/dynamic-top-change-002-ref.xht


I added

    p
    {
    line-height: 1.25;
    margin: 1em 0;
    }

    strong {line-height: 1;}

to those tests because, since a reftest must be using another method to
produce the same rendering layout, when using non-absolute-positioning,
then vertical margins can collapse, local fonts can create different
line box heights (18px or 19px or 20px).


You may want to check all these tests. I added comments explaining the
calculations of positions of static objects in the reftests.


I wanted to do the same thing for dynamic-top-change-005 but it was not
possible because
"
If such boxes are tall enough, there are multiple solutions and CSS 2.1
does not define the position of the line box's baseline
"
http://www.w3.org/TR/CSS21/visudet.html#line-height

and this seems to make Opera 12.02 position the glyphs (inside that 0px
height line box in those dynamic-top-change-005 tests) differently than
from other browsers. We can clearly see that the <p> sentence is a few
pixels upper in document box than other browsers; Opera DragonFly also
clearly shows this up. So, I stopped trying to make a reftest for
dynamic-top-change-005.

-----------------



http://test.csswg.org/suites/css2.1/nightly-unstable/html4/chapter-5.htm#s5.12.2

http://test.csswg.org/harness/test/CSS21_DEV/single/first-letter-quote-001/

http://test.csswg.org/harness/test/CSS21_DEV/single/first-letter-quote-002/

http://test.csswg.org/harness/test/CSS21_DEV/single/first-letter-quote-003/

http://test.csswg.org/harness/test/CSS21_DEV/single/first-letter-quote-004/

http://test.csswg.org/harness/test/CSS21_DEV/single/first-letter-quote-005/

http://test.csswg.org/harness/test/CSS21_DEV/single/first-letter-quote-006/

Boris, are you aware that there seems to be referencing issues with
first-letter-quote-001, 002, 003, 004, 005, 006 and their respective
reftests. When I do the test harness and arrive on these tests, I am
confused.

How could a test have more than 2 matching reftest to match? This would
be possible, I guess, if the spec allows 2 possible rendered layouts.
But anyway, a test can not serve as a reftest for another test... which
is what we have here.

Also, I would increase dramatically (say, 40px or 60px) the font-size in
those tests.

Gérard
-- 
Contributions to the CSS 2.1 test suite:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/

CSS 2.1 Test suite RC6, March 23rd 2011:
http://test.csswg.org/suites/css2.1/20110323/html4/toc.html

CSS 2.1 test suite harness:
http://test.csswg.org/harness/

Contributing to to CSS 2.1 test suite:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/web-authors-contributions-css21-testsuite.html
Received on Tuesday, 18 September 2012 01:44:55 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Tuesday, 18 September 2012 01:45:01 GMT