W3C home > Mailing lists > Public > public-css-testsuite@w3.org > August 2010

RE: Section 8.3.1 (margin collapsing) review report (= 39 tests out of 129 tests)

From: Gérard Talbot <css21testsuite@gtalbot.org>
Date: Thu, 12 Aug 2010 11:05:09 -0700
Message-ID: <400ce609b4dc212750feca7c4c771347.squirrel@cp3.shieldhost.com>
To: "Arron Eicholz" <Arron.Eicholz@microsoft.com>
Cc: "fantasai" <fantasai.lists@inkedblade.net>, "public-css-testsuite@w3.org" <public-css-testsuite@w3.org>
>> > Unless specified for "author: Ian Hickson", all individual comments
>> > refer to Microsoft's testcases.

Arron,

I did not identify the author as I said in the introduction for the last
9 reviewed testcases.... which I am doing now:

author: Ian Hickson
-------------------
{
http://test.csswg.org/suites/css2.1/20100727/html4/margin-collapse-102.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-collapse-103.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-collapse-104.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-collapse-106.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-collapse-110.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-collapse-111.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-collapse-112.htm
http://test.csswg.org/suites/css2.1/20100727/html4/margin-collapse-122.htm
http://test.csswg.org/suites/css2.1/20100727/html4/table-margin-004.htm
}

And in the last testcase review:
http://test.csswg.org/suites/css2.1/20100727/html4/table-margin-004.htm
it should have pointed to
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/table-margin-004-gt.html
and
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/table-margin-004-gt.xhtml


>> > - many testcases declare div {font: 20px/1 ahem;} when ahem font is
>> > not necessary
>>
>> Just a quick note on this last item -- if a test is made easier to use
>> by the use
>> of Ahem, even if it is not needed, then it is fine for the test to
>> request Ahem
>> in its style sheet as long as it doesn't flag Ahem as a requirement.
>>
>
> I disagree. The flag is still needed if you use the ahem font. The flag
> is there to tell you that you need to install the font before the test
> is run.

I agree with you that the flag should be there to tell the tester that
(s)he needs to install the font before the test is run.

> If you don't have the ahem font installed then you will most
> likely get really strange results.

What if you do not have the ahem font installed and if you do get
expected results in those testcases? .. and what if, after closer
examination, nothing in those testcases seem to require to have ahem
font installed?

In any case, - just making this very clear - not one testcase has been
rejected in my review report because it was requiring the ahem font even
though it - apparently - was not needed.

regards, Gérard
-- 
Contributions to the CSS 2.1 test suite:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/

CSS 2.1 test suite (beta 2; July 27th 2010):
http://test.csswg.org/suites/css2.1/20100727/html4/toc.html

CSS 2.1 test suite contributors:
http://test.csswg.org/source/contributors/
Received on Thursday, 12 August 2010 18:05:45 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Monday, 20 September 2010 17:52:02 GMT