W3C home > Mailing lists > Public > public-css-testsuite@w3.org > August 2010

Re: Incorrect link@rel='help' causing tests to be missing from TOC

From: Geoffrey Sneddon <gsneddon@opera.com>
Date: Thu, 05 Aug 2010 17:40:27 +0200
Message-ID: <4C5ADB6B.3090106@opera.com>
To: public-css-testsuite@w3.org, Arron.Eicholz@microsoft.com
CC: Boris Zbarsky <bzbarsky@MIT.EDU>, fantasai <fantasai@inkedblade.net>
On 05/08/10 16:33, Geoffrey Sneddon wrote:
> The following files all contain links to #first-line, which doesn't
> exist, they should all be #first-line-pseudo:
>
>> contributors/mozilla/submitted/css2.1/selectors/first-line-001.xht
>> contributors/mozilla/submitted/css2.1/selectors/first-line-floats-001.xht
>> contributors/mozilla/submitted/css2.1/selectors/first-line-floats-002.xht
>> contributors/mozilla/submitted/css2.1/selectors/first-line-floats-003.xht
>> contributors/mozilla/submitted/css2.1/selectors/first-line-floats-004.xht
>> contributors/mozilla/submitted/css2.1/selectors/first-line-inherit-001.xht
>>
>> contributors/mozilla/submitted/css2.1/selectors/first-line-inherit-002.xht
>>
>> contributors/mozilla/submitted/css2.1/selectors/first-line-inherit-003.xht

Further TCs with links that aren't sections appearing in the TOC:

> Error in contributors/microsoft/submitted/Chapter_4/whitespace-001.xht: Unknown link: http://www.w3.org/TR/CSS21/syndata.html#whitespace
> Error in contributors/microsoft/submitted/Chapter_4/whitespace-002.xht: Unknown link: http://www.w3.org/TR/CSS21/syndata.html#whitespace

I'm not sure quite what they should be…

> They currently get added to the built test-suite, but don't appear in
> the TOC anywhere. Should probably add some error-checking in the
> build-system for this…

I did this in a really ugly way, adding the following else block to
"if self.sections.has_key(uri)":

else:
   e = Exception("Unknown link: %s" % uri)
   e.CSSTestLibErrorLocation = test.sourcepath
   self.errors.add(e)

Unsurprisingly, this shows up a lot of tests that have links to places 
which aren't sections in addition to ones that cause them to be added to 
the TOC, which seems entirely reasonable.

-- 
Geoffrey Sneddon — Opera Software
<http://gsnedders.com/>
<http://www.opera.com/>
Received on Thursday, 5 August 2010 15:41:19 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Monday, 20 September 2010 17:52:02 GMT