W3C home > Mailing lists > Public > public-css-testsuite@w3.org > December 2007

Re: CSS 2.1 tests: again (II)

From: fantasai <fantasai.lists@inkedblade.net>
Date: Fri, 21 Dec 2007 15:54:25 -0500
Message-ID: <476C2801.2080708@inkedblade.net>
To: Gabriele Romanato <gabriele.romanato@gmail.com>
CC: css test <public-css-testsuite@w3.org>


Gabriele Romanato wrote:
> Just finished to upload the new tests:
>
> basic/atomic
> http://www.css-zibaldone.com/test/more/css21.zip

I've been looking at some of David Baron's tests, and he's
using 'background' instead of 'color'. That makes the red/green
easier to see, so I'd suggest doing that in the future. But your
existing tests are fine as-is, so you don't need to change them
unless you want to.

There are a few tests here that could have more specific titles
and assertions, but since they're otherwise ok I'm just going to
make the changes and add them rather than asking you to resubmit.
I've noted which tests are added and what changed:

char0.html

   I'd suggest mixing up the escape syntax here: adding
   zeros to test the different escape lengths and throwing
   in whitespace to make sure it gets swallowed.

char1.html

   Added as
     filename: escapes-009.xht
     title   : Incorrect Keyword Letter Escape
     assert  : Backslash cannot escape a hex digit.

char2.html

   Added as
     filename: escapes-010.xht
     title   : Unicode-escaped Braces
     assert  : Unicode escapes cannot substitute for '{' or '}' in CSS syntax.

char3.html

   David Baron has already written almost exactly the same test
     http://www.w3.org/Style/CSS/Test/CSS2.1/current/xhtml1/t040103-ident-08-c.xht
   so I think we will skip this one.

char4.html, char5.html, char6.html, char7.html, char8.html,

   These are actually invalid XHTML because XHTML doesn't allow '-', '@', or '_'
   at the beginning of IDs. David Baron and Ray Kiddy put together some tests
   that work around this issue, here:
     http://www.w3.org/Style/CSS/Test/CSS2.1/current/xhtml1/t040103-ident-02-c.xht
     http://www.w3.org/Style/CSS/Test/CSS2.1/current/xhtml1/t040103-ident-03-c.xht

   So we will skip these, too.

char9.html

   This is an excellent test, and I can accept it as-is, but I'd like
   to suggest adding some more {color: red;} rules using escapes for
   other white space characters such as tab and space. Also, you can
   try adding similar rules with the escapes placed inside the braces.
   That will create a more comprehensive test.

   I'd also change the assertion to
     "Unicode escapes cannot substitute for whitespace in CSS syntax."

char10.html, char11.html

   Since these are both almost the same, I'm going to just take char11.html.
   Add a "help" link to
     http://www.w3.org/TR/CSS21/selector.html#matching-attrs
   and this is good to go.

char12.html

   This is also a very nice test. I suggest however adding a second
   red rule with the \20 after the keyword.

If you haven't already, I'm going to need you to fill out the form here:
   http://www.w3.org/2002/09/wbs/1/testgrants2-200409/
to give W3C permission to use your tests.

Thanks a lot for taking the time to do this, it's a great help~ I'll
get through all your tests eventually. :)

~fantasai
Received on Friday, 21 December 2007 20:54:41 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Monday, 20 September 2010 17:51:55 GMT