W3C home > Mailing lists > Public > public-audio@w3.org > July to September 2017

Re: review of contiguous IDL

From: Raymond Toy <rtoy@google.com>
Date: Wed, 20 Sep 2017 09:46:19 -0700
Message-ID: <CAE3TgXHouG7JZaP0UkRtbYkk+ug_PXLQ5Jm-YXJjNxZdgLLrMA@mail.gmail.com>
To: "Jerry Smith (WPT)" <jdsmith@microsoft.com>
Cc: Joe Berkovitz <joe@noteflight.com>, Audio Working Group <public-audio@w3.org>
Thanks to the reviewers for taking a look!

The changes have been merged and are now live.  Just in case, I added a
tag, pre-conversion-to-contiguous-idl, to mark the point just before the
merge so we can go back and look at the old version in case we notice
something is missing or changed inadvertently.

So now you have no excuse for fixing all the outstanding v1 blocker issues!
;-)

On Mon, Sep 18, 2017 at 2:59 PM, Jerry Smith (WPT) <jdsmith@microsoft.com>
wrote:

> I just went through the WebIDL as well.  I posted three comments, but
> suspect 2 of the 3 things I noted were intentional.  The other is a small
> unrelated typo.
>
>
>
> *From:* Raymond Toy [mailto:rtoy@google.com]
> *Sent:* Monday, September 18, 2017 10:54 AM
> *To:* Joe Berkovitz <joe@noteflight.com>
> *Cc:* Audio Working Group <public-audio@w3.org>
> *Subject:* Re: review of contiguous IDL
>
>
>
> Thanks for the review.
>
>
>
> My current plan is to merge this to hte main branch on Wed morning
> (2017-09-20). Any remaining issues with the conversion will be fixed
> afterwards.
>
>
>
> So if you want to make comments, please review before Wed morning (PDT
> time).
>
>
>
> On Thu, Sep 14, 2017 at 3:04 PM, Joe Berkovitz <joe@noteflight.com> wrote:
>
> Hi Raymond,
>
>
>
> It turns out that I was able to get to this earlier than expected.
>
>
>
> I only found one missing thing in the updated version, described here:
>
>
>
>     https://github.com/WebAudio/web-audio-api/pull/1290#
> pullrequestreview-62899714
>
>
>
> All other content has carried over.
>
>
>
> Best,
>
> .            .       .    .  . ...Joe
>
>
>
>
>
Received on Wednesday, 20 September 2017 16:46:45 UTC

This archive was generated by hypermail 2.3.1 : Wednesday, 20 September 2017 16:46:46 UTC