Re: review of contiguous IDL

Fabulous -- thank you so much for landing this!

About V1 Blocker issues: what he said :-)

.            .       .    .  . ...Joe

Joe Berkovitz
Founder
Noteflight LLC

49R Day Street
Somerville MA 02144
USA

"Bring music to life"
www.noteflight.com

On Wed, Sep 20, 2017 at 12:46 PM, Raymond Toy <rtoy@google.com> wrote:

> Thanks to the reviewers for taking a look!
>
> The changes have been merged and are now live.  Just in case, I added a
> tag, pre-conversion-to-contiguous-idl, to mark the point just before the
> merge so we can go back and look at the old version in case we notice
> something is missing or changed inadvertently.
>
> So now you have no excuse for fixing all the outstanding v1 blocker
> issues! ;-)
>
> On Mon, Sep 18, 2017 at 2:59 PM, Jerry Smith (WPT) <jdsmith@microsoft.com>
> wrote:
>
>> I just went through the WebIDL as well.  I posted three comments, but
>> suspect 2 of the 3 things I noted were intentional.  The other is a small
>> unrelated typo.
>>
>>
>>
>> *From:* Raymond Toy [mailto:rtoy@google.com]
>> *Sent:* Monday, September 18, 2017 10:54 AM
>> *To:* Joe Berkovitz <joe@noteflight.com>
>> *Cc:* Audio Working Group <public-audio@w3.org>
>> *Subject:* Re: review of contiguous IDL
>>
>>
>>
>> Thanks for the review.
>>
>>
>>
>> My current plan is to merge this to hte main branch on Wed morning
>> (2017-09-20). Any remaining issues with the conversion will be fixed
>> afterwards.
>>
>>
>>
>> So if you want to make comments, please review before Wed morning (PDT
>> time).
>>
>>
>>
>> On Thu, Sep 14, 2017 at 3:04 PM, Joe Berkovitz <joe@noteflight.com>
>> wrote:
>>
>> Hi Raymond,
>>
>>
>>
>> It turns out that I was able to get to this earlier than expected.
>>
>>
>>
>> I only found one missing thing in the updated version, described here:
>>
>>
>>
>>     https://github.com/WebAudio/web-audio-api/pull/1290#pullrequ
>> estreview-62899714
>>
>>
>>
>> All other content has carried over.
>>
>>
>>
>> Best,
>>
>> .            .       .    .  . ...Joe
>>
>>
>>
>>
>>
>
>

Received on Wednesday, 20 September 2017 16:58:38 UTC