- From: Raphael Kubo da Costa via GitHub <sysbot+gh@w3.org>
- Date: Tue, 30 Jan 2024 17:13:05 +0000
- To: public-geolocation@w3.org
Thanks @anssiko for all the work so far, and apologies for the time it took for me to comment here. From a testing perspective, I feel like the tests in WPT need to be improved: - The existing ones still use MojoJS mocks and aren't very easy to use by non-Chromium implementations. There is ongoing work by @JuhaVainio to convert them to WebDriver; a patch should be submitted for review in the next few days. Not sure if this is a blocker for pinging the TAG though. - We need new tests for changes that went in since the 2016 CR, namely requestPermission() and Permissions API integration and integration with the Permissions Policy spec. @JuhaVainio is planning on working on both this quarter. I feel like these are good to have, but not blockers for a new TAG review. -- GitHub Notification of comment by rakuco Please view or discuss this issue at https://github.com/w3c/deviceorientation/issues/130#issuecomment-1917516374 using your GitHub account -- Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Tuesday, 30 January 2024 17:13:08 UTC