W3C home > Mailing lists > Public > www-voice@w3.org > January to March 2013

ISSUE-827: bug in detecting final states [SCXML-LC-Comments]

From: Voice Browser Working Group Issue Tracker <sysbot+tracker@w3.org>
Date: Tue, 29 Jan 2013 14:10:47 +0000
Message-Id: <E1U0Btf-0003cv-Td@tibor.w3.org>
To: w3c-voice-wg@w3.org,www-voice@w3.org
ISSUE-827: bug in detecting final states [SCXML-LC-Comments]

https://www.w3.org/Voice/Group/track/issues/827

Raised by: James Barnett
On product: SCXML-LC-Comments

>From Gavin Kistner:

Consider this test case:

    <scxml xmlns="http://www.w3.org/2005/07/scxml" version="1.0" name="HistoryTest">
      <state id="s" initial="s1">
        <state id="s1">
          <onentry><raise event="go"/></onentry>
          <transition event="go" target="pass"/>
        </state>
        <final id="pass"/>
      </state>
    </scxml>

And this test runner:

    final2 = RXSCy.Machine(@data['final2']).start
    assert(final2.is_active?('pass'),"final2 should pass")
    refute(final2.running?,"final2 should not be running")

In my interpreter, the first assertion works, but the second fails. The state machine enters the 'pass' final state, but the `running` flag is never set to false.

Looking at the algorithm, I don't see where it this case is covered. There are only two spots where running is set to false. The first is when receiving an external cancel event during the mainEventLoop, and the other is at the end of enterStates:

    for s in configuration:
            if isFinalState(s) and isScxmlState(s.parent):
                running = false

1) Is my test case wrong? Should entering the 'pass' final above not kill the interpreter?
2) Or should the above pseudo-code be `if isInFinalState(s) and isScxmlState(s.parent)"`?
Received on Tuesday, 29 January 2013 14:10:48 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Tuesday, 29 January 2013 14:10:50 GMT