W3C home > Mailing lists > Public > www-validator@w3.org > August 2008

Re: checklink: problems with separators in quiet text output

From: Michael Ernst <mernst@alum.mit.edu>
Date: Tue, 26 Aug 2008 23:07:59 +0200
Message-ID: <18612.28847.101042.557741@swsmde.ds.mpi-sws.mpg.de>
To: Ville Skyttä <ville.skytta@iki.fi>
Cc: www-validator@w3.org

Ville-

> > 1. checklink omits the "processing http://foo.com/my/webpage.html" output,
> > so the output gives no indication of which page the errors are on.
> 
> Your patch for this has been applied in CVS, thanks.  However I think it has 
> introduced a bit of a problem: the HTML output now contains the "Processing: 
> http://..." twice, at least for the first checked URL in non-summary-only 
> mode.  Could you have a look?

There was duplicate code that should have been deleted.  The patch below
removes it, and eliminates the duplicates for the situation you noted.

                    -Mike



diff -u -b -r --exclude=CVS --exclude=.hg --exclude=.hgtags --exclude=.hg --exclude=.svn /DS/home-0/mernst/bin/src/perl/W3C-LinkChecker/perl/modules/W3C/LinkChecker/bin/checklink.\~2\~ /DS/home-0/mernst/bin/src/perl/W3C-LinkChecker/perl/modules/W3C/LinkChecker/bin/checklink
--- /DS/home-0/mernst/bin/src/perl/W3C-LinkChecker/perl/modules/W3C/LinkChecker/bin/checklink.~2~	2008-08-26 22:52:04.053990661 +0200
+++ /DS/home-0/mernst/bin/src/perl/W3C-LinkChecker/perl/modules/W3C/LinkChecker/bin/checklink	2008-08-26 23:04:28.655398108 +0200
@@ -888,14 +888,6 @@
       $Opts{Exclude_Docs}) if defined($Opts{Exclude_Docs});
   }
 
-  unless ($Opts{Quiet}) {
-    if ($Opts{HTML}) {
-      printf("<h2>Processing %s</h2>\n", &show_url($absolute_uri));
-    } else {
-      print "\nProcessing\t$absolute_uri\n\n";
-    }
-  }
-
   if ($Opts{HTML}) {
     if (! $Opts{Summary_Only}) {
       my $accept = &encode($Accept);

Diff finished.  Tue Aug 26 23:04:38 2008
Received on Tuesday, 26 August 2008 21:08:42 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Wednesday, 25 April 2012 12:14:30 GMT