W3C home > Mailing lists > Public > www-validator-cvs@w3.org > August 2010

link-checker commit: Use PERL5LIB from environment even in taint mode, thanks to people on cpan-testers-discuss for assistance.

From: Mercurial notifier <nobody@w3.org>
Date: Thu, 05 Aug 2010 14:47:20 +0000
To: link-checker updates <www-validator-cvs@w3.org>
Message-Id: <E1Oh1j6-0006ED-JM@blinky.w3.org>
changeset:   297:a94236b02ff1
user:        ville
date:        Thu Feb 19 20:21:11 2009 +0000
files:       META.yml Makefile.PL bin/checklink docs/checklink.html
description:
Use PERL5LIB from environment even in taint mode, thanks to people on cpan-testers-discuss for assistance.


diff -r 75e6c9d6be31 -r a94236b02ff1 META.yml
--- a/META.yml	Thu Feb 19 20:18:26 2009 +0000
+++ b/META.yml	Thu Feb 19 20:21:11 2009 +0000
@@ -24,6 +24,7 @@
     LWP::UserAgent:                0
     Net::hostent:                  0
     Net::IP:                       0
+    perl5lib:                      0
     Socket:                        0
     Term::ReadKey:                 2
     Test::More:                    0
diff -r 75e6c9d6be31 -r a94236b02ff1 Makefile.PL
--- a/Makefile.PL	Thu Feb 19 20:18:26 2009 +0000
+++ b/Makefile.PL	Thu Feb 19 20:21:11 2009 +0000
@@ -15,6 +15,7 @@
                      HTTP::Response   => 1.50,
                      LWP::RobotUA     => 1.19,
                      LWP::UserAgent   => 0,
+                     perl5lib         => 0,
                      Time::HiRes      => 0,
                      URI              => 1.31,
                      URI::Escape      => 0,
diff -r 75e6c9d6be31 -r a94236b02ff1 bin/checklink
--- a/bin/checklink	Thu Feb 19 20:18:26 2009 +0000
+++ b/bin/checklink	Thu Feb 19 20:21:11 2009 +0000
@@ -5,7 +5,7 @@
 # (c) 1999-2009 World Wide Web Consortium
 # based on Renaud Bruyeron's checklink.pl
 #
-# $Id: checklink,v 4.148 2009-02-19 19:59:12 ville Exp $
+# $Id: checklink,v 4.149 2009-02-19 20:21:11 ville Exp $
 #
 # This program is licensed under the W3C(r) Software License:
 #       http://www.w3.org/Consortium/Legal/copyright-software
@@ -28,6 +28,15 @@
 # Get rid of potentially unsafe and unneeded environment variables.
 delete(@ENV{qw(IFS CDPATH ENV BASH_ENV)});
 $ENV{PATH} = ''; # undef would output warnings with Perl 5.6.1's Cwd.pm.
+
+# ...but we want PERL5LIB honored even in taint mode, see perlsec, perl5lib,
+# http://www.mail-archive.com/cpan-testers-discuss%40perl.org/msg01064.html
+BEGIN {
+  # undefinedness and "v-string in use/require non-portable" warnings with
+  # perl5lib 1.02 and perl 5.10.0, rt.cpan.org #43443, #43446
+  local $^W = 0;
+  require perl5lib;
+}
 
 # -----------------------------------------------------------------------------
 
@@ -268,7 +277,7 @@
   $PROGRAM     = 'W3C-checklink';
   $VERSION     = '4.4';
   $REVISION    = sprintf('version %s (c) 1999-2009 W3C', $VERSION);
-  my ($cvsver) = q$Revision: 4.148 $ =~ /(\d+[\d\.]*\.\d+)/;
+  my ($cvsver) = q$Revision: 4.149 $ =~ /(\d+[\d\.]*\.\d+)/;
   $AGENT       = sprintf('%s/%s [%s] %s',
                          $PROGRAM, $VERSION, $cvsver,
                          (W3C::UserAgent::USE_ROBOT_UA
diff -r 75e6c9d6be31 -r a94236b02ff1 docs/checklink.html
--- a/docs/checklink.html	Thu Feb 19 20:18:26 2009 +0000
+++ b/docs/checklink.html	Thu Feb 19 20:21:11 2009 +0000
@@ -6,7 +6,7 @@
     <title>W3C Link Checker Documentation</title>
     <link rev="made" href="mailto:www-validator@w3.org" />
     <style type="text/css" media="all">@import "linkchecker.css";</style>
-    <meta name="revision" content="$Id: checklink.html,v 1.50 2009-02-10 18:47:39 ville Exp $" />
+    <meta name="revision" content="$Id: checklink.html,v 1.51 2009-02-19 20:21:11 ville Exp $" />
   </head>
 
   <body>
@@ -151,6 +151,7 @@
 	  <li><a href="http://search.cpan.org/dist/HTML-Parser/">HTML-Parser</a> (version 3.20 or newer)</li>
 	  <li><a href="http://search.cpan.org/dist/libwww-perl/">libwww-perl</a> (version 5.802 or newer)</li>
           <li><a href="http://search.cpan.org/dist/Net-IP/">Net-IP</a> (optional but recommended; required for restricting access to <a href="http://www.ietf.org/rfc/rfc1918.txt">private IP addresses</a>)</li>
+          <li><a href="http://search.cpan.org/dist/perl5lib/">perl5lib</a></li>
           <li><a href="http://search.cpan.org/dist/TermReadKey/">TermReadKey</a> (optional but recommended; required only in command line mode for password input)</li>
 	  <li><a href="http://search.cpan.org/dist/Time-HiRes/">Time-HiRes</a></li>
 	  <li><a href="http://search.cpan.org/dist/URI/">URI</a> (version 1.31 or newer)</li>
@@ -309,7 +310,7 @@
         alt="Valid XHTML Strict" /></a>
       <a title="Send Feedback for the W3C Link Checker"
         href="http://validator.w3.org/feedback.html">The W3C Validator Team</a><br />
-      $Date: 2009-02-10 18:47:39 $
+      $Date: 2009-02-19 20:21:11 $
     </address>
     <p class="copyright">
       <a rel="Copyright" href="http://www.w3.org/Consortium/Legal/ipr-notice#Copyright">Copyright</a> &copy; 1994-2009
Received on Thursday, 5 August 2010 14:47:32 UTC

This archive was generated by hypermail 2.3.1 : Wednesday, 7 January 2015 15:17:44 UTC