W3C home > Mailing lists > Public > www-validator-cvs@w3.org > September 2009

2006/unicorn/src/org/w3c/unicorn/action ObserveAction.java,1.19,1.20

From: Thomas Gambet via cvs-syncmail <cvsmail@w3.org>
Date: Tue, 08 Sep 2009 15:30:29 +0000
To: www-validator-cvs@w3.org
Message-Id: <E1Ml2eL-0000rB-1d@lionel-hutz.w3.org>
Update of /sources/public/2006/unicorn/src/org/w3c/unicorn/action
In directory hutz:/tmp/cvs-serv3260/src/org/w3c/unicorn/action

Modified Files:
	ObserveAction.java 
Log Message:
added logs

Index: ObserveAction.java
===================================================================
RCS file: /sources/public/2006/unicorn/src/org/w3c/unicorn/action/ObserveAction.java,v
retrieving revision 1.19
retrieving revision 1.20
diff -u -d -r1.19 -r1.20
--- ObserveAction.java	8 Sep 2009 15:15:27 -0000	1.19
+++ ObserveAction.java	8 Sep 2009 15:30:26 -0000	1.20
@@ -164,13 +164,14 @@
 						aUnicornCall.setInputParameterValue(aFileItemUploaded);
 						aUnicornCall.setEnumInputMethod(EnumInputMethod.UPLOAD);
 					} else {
-						// TODO log "ucn_file not an instance of FileItem ?"
+						// should be impossible (see getRequestParameters)
+						logger.warn("ucn_file is not of type FileItem!");
 					}
 				} else if (paramName.equals("text_mime")) {
 					aUnicornCall.addParameter(paramPrefix + "mime", (String) reqParams.get(key));
 				} else {
 					logger.debug("Unknown parameter: " + key + " - " + (String) reqParams.get(key) +". This parameter is added to aUnicornCall.");
-					aUnicornCall.addParameter(key, (String) reqParams.get(key));
+					aUnicornCall.addParameter(key, reqParams.get(key).toString());
 				}
 			}
 		}
@@ -259,7 +260,7 @@
 				} else if (aFileItem.getFieldName().equals(Property.get("UNICORN_PARAMETER_PREFIX") + "file")) {
 					params.put(aFileItem.getFieldName(), aFileItem);
 				} else {
-					// TODO log "unknown fileItem, ignored"
+					logger.warn("Unknown FileItem in request: " + aFileItem.getFieldName());
 				}
 			}
 		} else {
Received on Tuesday, 8 September 2009 15:30:37 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Thursday, 26 April 2012 12:55:14 GMT