- From: Ville Skytta via cvs-syncmail <cvsmail@w3.org>
- Date: Wed, 25 Nov 2009 19:09:41 +0000
- To: www-validator-cvs@w3.org
Update of /sources/public/validator/httpd/cgi-bin
In directory hutz:/tmp/cvs-serv15854/httpd/cgi-bin
Modified Files:
check sendfeedback.pl
Log Message:
Fix indirect syntax calls flagged by perlcritic.
Index: sendfeedback.pl
===================================================================
RCS file: /sources/public/validator/httpd/cgi-bin/sendfeedback.pl,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -d -r1.15 -r1.16
--- sendfeedback.pl 24 Nov 2009 18:58:59 -0000 1.15
+++ sendfeedback.pl 25 Nov 2009 19:09:39 -0000 1.16
@@ -67,7 +67,7 @@
# Get rid of (possibly insecure) $PATH.
delete $ENV{PATH};
-our $q = new CGI;
+our $q = CGI->new();
our $lang = 'en_US'; # @@@ TODO: conneg
# Read error message + explanations file
Index: check
===================================================================
RCS file: /sources/public/validator/httpd/cgi-bin/check,v
retrieving revision 1.730
retrieving revision 1.731
diff -u -d -r1.730 -r1.731
--- check 24 Nov 2009 19:07:44 -0000 1.730
+++ check 25 Nov 2009 19:09:39 -0000 1.731
@@ -239,7 +239,7 @@
#
# Create a new CGI object.
-my $q = new CGI;
+my $q = CGI->new();
#
# The data structure that will hold all session data.
@@ -1009,7 +1009,7 @@
sub compoundxml_validate (\$)
{
my $File = shift;
- my $ua = new W3C::Validator::UserAgent($CFG, $File);
+ my $ua = W3C::Validator::UserAgent->new($CFG, $File);
$File->{ParserName} = "validator.nu";
$File->{ParserOpts} = "";
@@ -1164,7 +1164,7 @@
sub html5_validate (\$)
{
my $File = shift;
- my $ua = new W3C::Validator::UserAgent($CFG, $File);
+ my $ua = W3C::Validator::UserAgent->new($CFG, $File);
$File->{ParserName} = "validator.nu";
$File->{ParserOpts} = "";
@@ -1691,10 +1691,10 @@
my $q = shift; # The CGI object.
my $File = shift; # The master datastructure.
- my $uri = new URI(ref $q ? $q->param('uri') : $q)->canonical();
+ my $uri = URI->new(ref $q ? $q->param('uri') : $q)->canonical();
$uri->fragment(undef);
- my $ua = new W3C::Validator::UserAgent($CFG, $File);
+ my $ua = W3C::Validator::UserAgent->new($CFG, $File);
unless ($ua->is_protocol_supported($uri)) {
$File->{'Error Flagged'} = TRUE;
@@ -1716,7 +1716,7 @@
return $File unless $ua->uri_ok($uri);
- my $req = new HTTP::Request(GET => $uri);
+ my $req = HTTP::Request->new(GET => $uri);
# if one wants to use the accept, accept-charset and accept-language params
# in order to trigger specific negotiation
Received on Wednesday, 25 November 2009 19:09:52 UTC