W3C home > Mailing lists > Public > www-validator-cvs@w3.org > November 2009

validator/httpd/cgi-bin check,1.727,1.728 sendfeedback.pl,1.14,1.15

From: Ville Skytta via cvs-syncmail <cvsmail@w3.org>
Date: Tue, 24 Nov 2009 18:59:01 +0000
To: www-validator-cvs@w3.org
Message-Id: <E1ND0bN-0005If-Bb@lionel-hutz.w3.org>
Update of /sources/public/validator/httpd/cgi-bin
In directory hutz:/tmp/cvs-serv20339/httpd/cgi-bin

Modified Files:
	check sendfeedback.pl 
Log Message:
Fix perlcritic "Heredoc terminator must be quoted" errors.

Index: sendfeedback.pl
===================================================================
RCS file: /sources/public/validator/httpd/cgi-bin/sendfeedback.pl,v
retrieving revision 1.14
retrieving revision 1.15
diff -u -d -r1.14 -r1.15
--- sendfeedback.pl	23 Nov 2009 22:24:15 -0000	1.14
+++ sendfeedback.pl	24 Nov 2009 18:58:59 -0000	1.15
@@ -55,7 +55,7 @@
         $CFG = \%cfg;
     };
     if ($@) {
-        die <<EOF;
+        die <<"EOF";
 Could not read configuration.  Set the W3C_VALIDATOR_CFG environment variable
 or copy conf/* to /etc/w3c/. Make sure that the configuration file and all
 included files are readable by the web server user. The error was:\n'$@'

Index: check
===================================================================
RCS file: /sources/public/validator/httpd/cgi-bin/check,v
retrieving revision 1.727
retrieving revision 1.728
diff -u -d -r1.727 -r1.728
--- check	24 Nov 2009 18:53:34 -0000	1.727
+++ check	24 Nov 2009 18:58:59 -0000	1.728
@@ -133,7 +133,7 @@
         $CFG = \%cfg;
     };
     if ($@) {
-        die <<EOF;
+        die <<"EOF";
 Could not read configuration.  Set the W3C_VALIDATOR_CFG environment variable
 or copy conf/* to /etc/w3c/. Make sure that the configuration file and all
 included files are readable by the web server user. The error was:\n'$@'
@@ -148,12 +148,8 @@
         my @_d    = grep { not $paths{$_}->[0] } keys %paths;
         my @_r    = grep { not $paths{$_}->[1] } keys %paths;
         return TRUE if (scalar(@_d) + scalar(@_r) == 0);
-        die <<EOF   if scalar @_d;
-Does not exist or is not a directory: @_d
-EOF
-        die <<EOF if scalar @_r;
-Directory not readable (permission denied): @_r
-EOF
+        die "Does not exist or is not a directory: @_d\n"       if scalar(@_d);
+        die "Directory not readable (permission denied): @_r\n" if scalar(@_r);
     }
 
     #
Received on Tuesday, 24 November 2009 18:59:02 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Thursday, 26 April 2012 12:55:15 GMT