W3C home > Mailing lists > Public > www-svg@w3.org > February 2008

SVGt 1.2 Tests: 3 possible problems in struct tests

From: Kalle Raita <kraita@nvidia.com>
Date: Tue, 12 Feb 2008 16:33:37 +0100
Message-ID: <85DD8D3F1695004A8A9A5AC16CE584BE054C264F@deemmail01.nvidia.com>
To: <www-svg@w3.org>

Our opinion is that the following 3 struct tests are faulty as detailed
below.

== struct-svg-201-t ==
>From line 54:
	var fs = svg.getFloatTrait("snapshotTime");
	if(fs == "3")
	{
This amounts to a float value compared against a string, which
is a type mismatch.
Moreover, constructing floats from strings cannot be guaranteed produce
same result across implementations. The returned float valued could 
theoretically be in this case 2.99999 or 3.000001 depending on
implementation. 
Suggested fix: Get trait as string or require that 2.999 < fs < 3.001.


== struct-svg-203-t ==
The test uses SVG 1.1 Basic features and the reference image shows the
result
for an implementation that supports SVG 1.1 Basic. The test does not in
any way
indicate that both results are acceptable. What is the purpose of this
test from 
the SVGt 1.2 conformance point of view? 
Suggested fix: remove this test entirely.

== struct-discard-202-t ==
>From line 25:
      <rect x="100" y="50" width="100" height="100" fill="red">
		<discard xml:id="discard1"
begin="circleanim.repeat(1)"/>
	</rect>
And line 44
	<discard xlink:href="#discard1" begin="1s"/>

circleanim.repeat(1) should happen at 5s, so the latter discard gets
executed at 1s 
and discards the discard animation at line 26. The reference image
suggests that 
the expected result is that the discard at line 26 gets activated and
the top-left
circle is exposed. 
Suggested fix: Either update the reference image to show red rectangle
in top-left
corner or remove the last discard animation.
 
Yours,
  - Kalle Raita

Kalle Raita 
NVIDIA Corporation 
Tel. +358 40 723 1441 
kraita@nvidia.com 
http://eu.nvidia.com <http://eu.nvidia.com/>  

-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
Received on Tuesday, 12 February 2008 15:37:21 GMT

This archive was generated by hypermail 2.3.1 : Friday, 8 March 2013 15:54:38 GMT