W3C home > Mailing lists > Public > www-style@w3.org > June 2014

Re: [css-font-loading] FontFaceSet should inherit from EventTarget

From: Tab Atkins Jr. <jackalmage@gmail.com>
Date: Wed, 25 Jun 2014 17:59:12 -0700
Message-ID: <CAAWBYDD7PqGDdmf6yVFt0DMVuA7Lwr-c4DrqZg5TRgbECeMUdg@mail.gmail.com>
To: Boris Zbarsky <bzbarsky@mit.edu>
Cc: www-style list <www-style@w3.org>
On Sat, Jun 21, 2014 at 11:42 AM, Tab Atkins Jr. <jackalmage@gmail.com> wrote:
> On Fri, Jun 20, 2014 at 10:55 PM, Boris Zbarsky <bzbarsky@mit.edu> wrote:
>> On 6/21/14, 1:39 AM, Tab Atkins Jr. wrote:
>>> I can do that, but aw, that's terrible.  Using inheritance for what is
>>> clearly a functionality mix-in is just a terrible abuse. :/
>>
>> It really depends on what your goals are in terms of behavior.
>>
>> If a library hooks EventTarget.prototype.addEventListener to do some
>> logging, would it expect addEventListener calls on a FontFaceSet to be
>> logged?  If so, then you want inheritance, not a mix-in.
>
> Right, I know how JS works, it's just a terrible pattern required by
> JS's weak support for mix-ins.  I'll make the change, though.

Done now.

~TJ
Received on Thursday, 26 June 2014 00:59:59 UTC

This archive was generated by hypermail 2.3.1 : Monday, 2 May 2016 14:39:22 UTC