W3C home > Mailing lists > Public > www-style@w3.org > July 2014

Re: [css-flexbox] Tweaking the old "resolving flexible lengths" algorithm to produce same behavior as new algorithm

From: Tab Atkins Jr. <jackalmage@gmail.com>
Date: Tue, 1 Jul 2014 11:00:51 -0700
Message-ID: <CAAWBYDBPfYbBk3ek5Lrho43QA7U6PpEdXZPxG9apoDCFS1HSnw@mail.gmail.com>
To: Daniel Holbert <dholbert@mozilla.com>
Cc: www-style list <www-style@w3.org>
On Tue, May 6, 2014 at 6:20 PM, Daniel Holbert <dholbert@mozilla.com> wrote:
> On 05/06/2014 05:59 PM, Tab Atkins Jr. wrote:
>> Okay, we've now temporarily added a "Redux" section to the spec with a
>> flex-distribution algo based on the older flex-factor-based algo, but
>> with the tweaks from the newest stuff.
>
> Thanks!
>
>> Let us know if you're happy with the redux section.
>
> Looks good to me! Just a few nits:
>
> a) This is the only mention of "target main size" in this redux section:
>
>   # 3. Calculate initial free space. [...] For frozen items,
>   #    use their outer target main size
>
> I'm guessing this is a typo -- this probably wants to just say "outer
> main size", or perhaps "frozen outer main size"?  Alternately, the rest
> of this section could be updated to also work with a "target main size".

Fixed this by using "target main size" throughout the algo.

> b) I think this wants s/all items/all unfrozen items/:
>
>    # If the free space is positive
>    #   Find the ratio of the item’s flex grow factor to
>    #   the sum of the flex grow factors of all items on
>    #   the line.
>
> c) I think this wants s/every item/every unfrozen item/:
>
>    # If the free space is negative
>    #   For every item on the line, multiply [...]
>
>
> d) I think this wants s/each item/each unfrozen item/:
>
>    # 4. Fix min/max violations. Clamp each item’s
>    #    main size [...]

All fixed.

~TJ
Received on Tuesday, 1 July 2014 18:01:38 UTC

This archive was generated by hypermail 2.3.1 : Monday, 2 May 2016 14:39:23 UTC