Re: [css3-syntax] Consumation of comment tokens during tree construction

Le 23/01/2013 03:05, Tab Atkins Jr. a écrit :
> On Mon, Jan 7, 2013 at 7:35 AM, Johannes Koch <koch@w3development.de> wrote:
>> Hi, here's a question about the Syntax Module Editor's Draft 5 January 2013:
>>
>> Comment tokens are only consumed in '3.5.9. Declaration-important mode'. IMO
>> they should also be consumed in '3.5.2. Top-level mode' together with
>> whitespace tokens and probably in other modes, too.
>
> Thanks for pointing this out.  I've added consumption clauses to all
> of the parser modes now.  If you don't mind, could you check and
> ensure I didn't make a mistake or miss anything?

As much as I dislike having to do this, shouldn’t some comment tokens be 
preserved where the tree has "lists of primitives" so it can be 
serialized back correctly? Namely:

* at-rule prelude
* selector
* declaration value

Example of pathological input:
border: 1px/**/solid

-- 
Simon Sapin

Received on Wednesday, 23 January 2013 08:46:08 UTC