W3C home > Mailing lists > Public > www-style@w3.org > September 2011

Re: [css3-flexbox] Typos in updated flexbox spec

From: Tab Atkins Jr. <jackalmage@gmail.com>
Date: Wed, 7 Sep 2011 14:28:45 -0700
Message-ID: <CAAWBYDCzcHrPHVD0N5v4r=eNfVYp4DF5sZhcgeU=VTZnvLDCag@mail.gmail.com>
To: Daniel Holbert <dholbert@mozilla.com>
Cc: www-style@w3.org
On Wed, Sep 7, 2011 at 1:51 PM, Daniel Holbert <dholbert@mozilla.com> wrote:
> Hi Tab,
>
> Just read through the updated flexbox spec
> ( http://dev.w3.org/csswg/css3-flexbox/ dated 3 September 2011)
> and I came across a few typos to report:

Thanks for taking the time!


>> 2. The Flexbox Box Model
> [...]
>> The flexbox layout algorithm works is agnostic as to the physical
>> direction the flexbox happens to be laid out in
>
> s/works is/is/

Fixed.


>> 2.1. New values for ‘display’ property
> [...]
>> Setting ‘display:flexbox’ on an element forces it to use a new layout
>> algorithm, and so some properties that were designed with the
>> assumption of block layout don't make sense in a flexbox context.
>
> The first line of this paragraph should probably mention (or be inclusive
> of) _both_ 'display:flexbox' _and_ 'inline-flexbox'.  (Maybe that's implied
> though (?))

Changed to just say "Flexboxes".


>> A flexbox item creates a new flexbox formatting context for its contents.
>> [...] the flexbox's margins do not collapse with any other margin.
>
> I think this is meant to say "the _flexbox items'_ margins do not collapse",
> right?  (I'm making that assumption since the spec is describing conditions
> for the flexbox's _contents_ here, and also because the flexbox itself is
> supposed to behave like a block as far as its external container is
> concerned, which I'd imagine would include margin-collapsing...? Not sure
> though.)

Man, I don't know what I was doing with that sentence.  Changed it to be sane:

# A flexbox creates a new flexbox formatting context
# for its contents.  This is similar to a block
# formatting context: floats must not intrude into
# the flexbox, and the flexbox's margins do not
# collapse with the margins of its contents.


>> 5.1. Main Axis Alignment: the ‘flex-pack’ property
> [...]
>> The ‘flex-pack’ property aligns flexbox items in the main axis of the
>> current line of the flexbox. This is done after any flexible lengths [...]
>
> Here, the word "after" (in "This is done after") is mistakenly linkified to
> #flex-align-after, in the spec HTML.

Good catch.  Made it stop trying to link.


>> 5.2. Cross Axis Alignment: the ‘flex-align’ property
> [...]
>> Value:        start | end | center | baseline | stretch
> [...]
>> [definitions of values' meaning, including "before",
>> "after", "middle", "baseline", "stretch"]
>
> The labels "before"/"after"/"middle" in the value definitions here don't
> match the labels in the "Values:" line.

Hmm, dunno how I missed that.  Changed them to start/end/center as
they should be.

~TJ
Received on Wednesday, 7 September 2011 21:29:32 GMT

This archive was generated by hypermail 2.3.1 : Tuesday, 26 March 2013 17:20:44 GMT