Re: [css3-multicol] tests submitted

Hi Håkon, 

a few quick comments:

1) The test titles should be more descriptive, not just the filename
2) You really, really need to add links to the appropriate section of the specification (the test harness needs these, the build system will soon, and it's just good form)
3) Please add an assertion
4) Don't forget any requirement flags, if applicable
5) Ideally, new tests should be self-describing reftests

Peter

[1] http://wiki.csswg.org/test/css2.1/format#title-element
[2] http://wiki.csswg.org/test/css2.1/format#specification-links
[3] http://wiki.csswg.org/test/css2.1/format#test-assertions
[4] http://wiki.csswg.org/test/css2.1/format#requirement-flags
[5] http://wiki.csswg.org/test/reftest

On May 15, 2011, at 12:12 PM, Håkon Wium Lie wrote:

> I've submitted the beginnings of an automated test suite:
> 
> http://test.csswg.org/source/contributors/howcome/submitted/multicol-basic-000.xht
> http://test.csswg.org/source/contributors/howcome/submitted/multicol-basic-001.xht
> http://test.csswg.org/source/contributors/howcome/submitted/multicol-basic-002.xht
> http://test.csswg.org/source/contributors/howcome/submitted/multicol-basic-003.xht
> http://test.csswg.org/source/contributors/howcome/submitted/multicol-break-000.xht
> http://test.csswg.org/source/contributors/howcome/submitted/multicol-fill-000.xht
> http://test.csswg.org/source/contributors/howcome/submitted/multicol-fill-001.xht
> http://test.csswg.org/source/contributors/howcome/submitted/multicol-gap-000.xht
> http://test.csswg.org/source/contributors/howcome/submitted/multicol-overflow-000.xht
> http://test.csswg.org/source/contributors/howcome/submitted/multicol-reduce-000.xht
> http://test.csswg.org/source/contributors/howcome/submitted/multicol-rule-000.xht
> http://test.csswg.org/source/contributors/howcome/submitted/multicol-rule-001.xht
> http://test.csswg.org/source/contributors/howcome/submitted/multicol-rule-dashed-000.xht
> http://test.csswg.org/source/contributors/howcome/submitted/multicol-rule-dotted-000.xht
> http://test.csswg.org/source/contributors/howcome/submitted/multicol-rule-double-000.xht
> http://test.csswg.org/source/contributors/howcome/submitted/multicol-rule-groove-000.xht
> http://test.csswg.org/source/contributors/howcome/submitted/multicol-rule-hidden-000.xht
> http://test.csswg.org/source/contributors/howcome/submitted/multicol-rule-inset-000.xht
> http://test.csswg.org/source/contributors/howcome/submitted/multicol-rule-none-000.xht
> http://test.csswg.org/source/contributors/howcome/submitted/multicol-rule-outset-000.xht
> http://test.csswg.org/source/contributors/howcome/submitted/multicol-rule-ridge-000.xht
> http://test.csswg.org/source/contributors/howcome/submitted/multicol-rule-solid-000.xht
> http://test.csswg.org/source/contributors/howcome/submitted/multicol-span-000.xht
> 
> The tests are fairly basic, but covers most of the specification.
> 
>  http://www.w3.org/TR/css3-multicol
> 
> For a more human-friendly test, this page contains (variations of) all
> the individual tests.
> 
>  http://people.opera.com/howcome/2011/tests/multicol.html
> 
> Cheers,
> 
> -h&kon
>              Håkon Wium Lie                          CTO °þe®ª
> howcome@opera.com                  http://people.opera.com/howcome
> 

Received on Sunday, 15 May 2011 23:08:29 UTC