Re: small errors in the CSS2.1 grammar

Lars Knoll writes:
> 
> Hi,
> 
> I have completely rewritten the CSS parser in khtml over the last months, and 

Yes, I noticed. I happened to be looking at the KDE CVS yesterday...

> by this occasion I stumbled over a small errors in the CSS 2.1 grammar:
> 
> "!{w}important"         {return IMPORTANT_SYM;}
> should be:
> "!"{w}"important"         {return IMPORTANT_SYM;}

Indeed.

> 
> My version of flex doesn't seem to handle the comment specification correctly 
> (the end of comments as eg "/***/" are not recognised for some reason), 
> although the expression looks correct to me:
> 
> \/\*[^*]*\*+([^/][^*]*\*+)*\/   /* ignore comments */
> 
> In khtml, I've gone back to the CSS1 grammar for the definition of comments.

They are supposed to be equivalent, so that should be OK.

I'll try to find out why the pattern doesn't work. I'll change the
pattern in CSS 2.1, if needed.



Bert
-- 
  Bert Bos                                ( W 3 C ) http://www.w3.org/
  http://www.w3.org/people/bos/                              W3C/INRIA
  bert@w3.org                             2004 Rt des Lucioles / BP 93
  +33 (0)4 92 38 76 92            06902 Sophia Antipolis Cedex, France