W3C home > Mailing lists > Public > www-lib@w3.org > October to December 2002

Fixed compile warning "comparison always true" [patch]

From: Richard Atterer <libwww@list02.atterer.net>
Date: Sat, 12 Oct 2002 21:24:39 +0200
To: www-lib@w3.org
Message-ID: <20021012192439.GA5001@nenya.lan>

Hello,

on machines where "char" is unsigned, the following compile time
warning is given by gcc:

/build/buildd/w3c-libwww-5.4.0/LineMode/src/HTBrowse.c:673: warning:
comparison is always true due to limited range of data type

It turns out this warning is bogus; the result of that comparison is
never used. The patch below removes the warning.

Cheers,

  Richard

-- 
  __   _
  |_) /|  Richard Atterer     |  CS student at the Technische  |  GnuPG key:
  | \/¯|  http://atterer.net  |  Universität München, Germany  |  0x888354F7
  ¯ '` ¯

--- LineMode/src/HTBrowse.c.orig	2002-10-12 20:47:09.000000000 +0200
+++ LineMode/src/HTBrowse.c	2002-10-12 21:14:59.000000000 +0200
@@ -670,7 +670,7 @@
     }
     HTRequest_setOutputStream(req, HTFWriter_new(req, fp, NO));
     if (SHOW_MSG) HTPrint("Saving to file `%s\'\n", fname);
-    return (HTLoadAnchor((HTAnchor*) HTMainAnchor, req) != HT_WOULD_BLOCK);
+    return HTLoadAnchor((HTAnchor*) HTMainAnchor, req);
 }
 
 CSError_t LoadedUsersCallback(CSUser_t * pCSUser, int index, void * pVoid)
Received on Saturday, 12 October 2002 15:45:45 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Monday, 23 April 2007 18:18:42 GMT