W3C home > Mailing lists > Public > www-lib@w3.org > April to June 2001

RE: Bug fixes

From: Jens Meggers <jens.meggers@firepad.com>
Date: Fri, 27 Apr 2001 18:49:46 -0700
Message-ID: <DDF913B74F07D411B22500B0D0206D9F4EF0B5@FIREPLUG>
To: "'Yusef_Badri@tertio.com'" <Yusef_Badri@tertio.com>, www-lib@w3.org
Cc: yb@greybox.demon.co.uk
Yusef,

thanks for providing the bug fixes. I checked all fixes. I have the
following comments:

Patch 1: OK
Patch 2: OK
Patch 3: 
This is a good improvement. It seems to me that we also should set the user
profgile to NULL if it is once deleted.
Thus, I also added the up = NULL in HTUserProfile_delete(). Seems to me that
nobody paid attention to this because they never reenter the lib.

PUBLIC BOOL HTUserProfile_delete (HTUserProfile * up)
{
    if (up) {
	HT_FREE(up->user);
	HT_FREE(up->fqdn);
	HT_FREE(up->email);
	HT_FREE(up->news);
	HT_FREE(up->tmp);
	HT_FREE(up);
	up = NULL;
	return YES;
    }
    return NO;
}


Patch 4:
Ok, I have done it already in 3. Seems to be a little bit more secure as
HTUserProfile_delete() cannot free two times.


Patch 5
Ok.

Patch 6
OK

Patch 7
Ok

Patch 8
ok

Patch 9

Your changes are looking ok, but I do not see the mem free error in the old
implmentation. I currently have the following code:

    if (cookie_holder) {

		HTList * cur = cookie_holder;
		HTCookieHolder * pres = NULL;
		while ((pres = (HTCookieHolder *) HTList_nextObject(cur))) {

		    HTCookieHolder_delete(pres);

		}

		HTList_delete(cookie_holder);
		cookie_holder = NULL;
		return YES;
    }

What is wrong with that?


Patch 10

ok. I also would perefer not to change the wwwstr.c function.


Patch 11

ok.

Patch 12

ok.



Thanks again for the input.


jens
Received on Friday, 27 April 2001 22:01:18 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Monday, 23 April 2007 18:18:39 GMT