Re: Configuring ProcessFilter. (fwd)

Julianne Freire de Sousa Pepeu writes:
 > 
 > On Tue, 3 Jun 1997, Anselm Baird_Smith wrote:
 > 
 > > Julianne Freire de Sousa Pepeu writes:
 > >  > 1. I point my browser to http://machine:8001/Admin/Editor/proxy
 > >  > 2. I follow the link to Add filter 
 > >  > 3. I write the class (w3c.jigsaw.filters.ProcessFilter)
 > >  > 4. Press Ok
 > >  > 5. I follow the link filter-0
 > >  > 6. and... "The process filter of this resource is not configured properly
 > >  > (it has no command)."
 > >  > 
 > >  > when I try to set the "command" attribute, the ProcessFilter is already
 > >  > working!
 > > 
 > > Oops, I see, this may be a bug in the ProcessFiltyer (check the
 > > initialize mtehod looking for the command attribute, remove anything
 > > there that checksd the command)
 > 
 > but the check of the "command" attribute is done in the outgoingFilter
 > method, and not in the initialize method! see the code...
 > 
 > public Reply outgoingFilter (Request request, Reply reply)
 >         throws HTTPException
 >     {
 >         Process       process   = null ;
 >         ProcessFeeder feeder    = null ;
 >         String        command[] = getCommand() ;
 > 
 >         // Some sanity checks:
 >         if (reply.getStatus() != HTTP.OK)
 >             return null;
 >         InputStream in = reply.openStream() ;
 >         if ( in == null )
 >             return null;
 >         if ( command == null ) {
 >             Reply error = request.makeReply(HTTP.INTERNAL_SERVER_ERROR) ;
 >             error.setContent("The process filter of this resource is not "
 >                            + " configured properly (it has no command).");
 >             throw new HTTPException(error);
 >         }

I think that's the bug: whenevr the target resource is looked up,
filters are applied (I guess), so even though you access the resource
through the editor, Jigsaw tries to apply the filter. Remove the
exception throwing here:

         if ( command == null ) {
               return null;
         }

Anselm
I will integrate that