- From: Glenn Maynard <glenn@zewt.org>
- Date: Sun, 13 Mar 2011 13:58:00 -0400
- To: Jonas Sicking <jonas@sicking.cc>
- Cc: Jacob Rossi <jrossi@microsoft.com>, Anne van Kesteren <annevk@opera.com>, Olli Pettay <Olli.Pettay@helsinki.fi>, "Olli@pettay.fi" <Olli@pettay.fi>, "www-dom@w3.org" <www-dom@w3.org>
On Sun, Mar 13, 2011 at 1:21 PM, Jonas Sicking <jonas@sicking.cc> wrote: >> Not all. WebKit doesn't check whether initEvent was called; it just >> checks whether event.type != "". If it's to allow e.type == "", it >> would need a new flag indicating whether initEvent was called. > > I don't see a reason to allow empty string as event name. I don't see > a strong reason to forbid it either, but since we need some sort of > state which indicates "event has been initied" then checking for empty > type seems fine. So we could make initEvent throw if called with an > empty type. If initEvent is to stay required, I think this is best. All else equal, reducing hidden state is a clear win. -- Glenn Maynard
Received on Sunday, 13 March 2011 17:58:33 UTC