W3C home > Mailing lists > Public > www-dom@w3.org > April to June 2011

Re: [DOMCore] Non-nullable objects

From: Ms2ger <ms2ger@gmail.com>
Date: Tue, 24 May 2011 09:17:21 +0200
Message-ID: <4DDB5B81.5040705@gmail.com>
To: "www-dom@w3.org" <www-dom@w3.org>
On 05/24/2011 12:59 AM, Cameron McCormack wrote:
> Ms2ger:
>> As Cameron has made objects non-nullable by default [1], I've
>> updated DOM Core accordingly. [2] I probably got some changes wrong,
>> and would appreciate review of this change.
>
> The detail argument of CustomEvent.initCustomEvent() should be
> “object?”.

Done

> I’m assuming that EventTarget.{add,remove}EventListener need to do
> nothing when passed null for their EventListener because existing
> content assumes it?  If not, I’d say it doesn’t make sense to allow
> null to be passed, and make the type “EventListener”.

I'd agree, but this seems like a risky change. If implementations are 
willing to change, I'm all for.

> The doctype argument to DOMImplementation.createDocument() should be
> “DocumentType?”.

Done

> Looks good otherwise.
>

Thanks!
Ms2ger

http://dvcs.w3.org/hg/domcore/rev/476041f61d77
Received on Tuesday, 24 May 2011 07:18:02 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Friday, 22 June 2012 06:14:07 GMT