W3C home > Mailing lists > Public > www-dom@w3.org > April to June 2001

Re: expandEntityReferences

From: Jonas Sicking <sicking@bigfoot.com>
Date: Thu, 24 May 2001 03:00:33 +0200
Message-ID: <015801c0e3ec$ef8483c0$d1ee42d5@kermit>
To: <www-dom@w3.org>
> > I don't quite understand how expandEntityReferences works on the
> > treeWalker and nodeIterator interfaces
>
> The text is actually correct as it stands, but badly phrased. My
apologies!
>
>    "The value of this flag determines whether the children of entity
>    reference nodes are visible to the iterator. If false, they and their
>    descendants will be rejected."
>
> The intended reading was that "they" means "the children of entity
> reference nodes". You misread it as meaning "entity reference nodes". I
> have to admit it took me a second glance to realize this myself, so it's
> probably worth considering this an editorial erratum. Proposed revised
> text:
>
>    "The value of this flag determines whether the children of entity
>    reference nodes are visible to the iterator. If false, those children
>    and their descendants will be rejected."
>
> Better?

I could be nitpicking here, but really says that all decenats of entity
references should be FILTER_REJECTed. But I guess that's not the intent if
currentNode of a treeWalker is set to a decendant of an entity reference. So
something like:

"The value of this flag determines whether the children of entity
reference nodes are visible. If false, the enity reference will
appear to have no children."

maybe?

/ Jonas Sicking
Received on Wednesday, 23 May 2001 20:57:38 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Friday, 22 June 2012 06:13:48 GMT