Album art broken in Win32 VLC HTTP Lua interface

Hi,

  vlc/lua/intf/http.lua in the current stable version does not work on
Windows as album art file references are file:///c:/... URLs and in the
code only `file://` is removed to make a local path, which probably has
the desired effect on systems where `/` is the local file path root. I
am not sure the operating system is exposed through some VLC API, Lua
itself does not usually expose this. Perhaps the code needs to scan for
the "letter:" part, or net.parse_url can be used instead to get a path.

Also, the code uses io.stat() to determine the size of the file, then it
reads it into memory whatever the size is, and then uses the stat() size
in the Content-Length header. That's racy, the Content-Length rather has
to be the true octet length of the file contents (#raw instead of size).

Also, most VideoLAN web sites, including the bug tracker, have been down
for a while, once again...

regards,
-- 
Björn Höhrmann · mailto:bjoern@hoehrmann.de · http://bjoern.hoehrmann.de
Am Badedeich 7 · Telefon: +49(0)160/4415681 · http://www.bjoernsworld.de
25899 Dagebüll · PGP Pub. KeyID: 0xA4357E78 · http://www.websitedev.de/

Received on Saturday, 22 October 2011 18:27:31 UTC