Re: Time for a point release?

Hi again,

On Sat, 2006-09-02 at 14:35 +0100, Paul wrote:
> Hi,
> 
> > > > A new snapshot of the future 9.52 version is now available.
> > > > See http://www.w3.org/Amaya/
> > > 
> > > And it's still won't compile
> > 
> > What error do you get ? I checked and built the snapshot without a
> > problem.
> 
> Running on Fedora Core 6 test 2, x86_64

OK, I don't have a 64 bits machine, so I can't see some build
failures...
> ../../annotlib/BMmenu.c: In function 'void
> BookmarkMenuCallbackDialog(int, int, char*)':
> ../../annotlib/BMmenu.c:438: error: cast from 'char*' to 'int' loses
> precision
> ../../annotlib/BMmenu.c: In function 'void TopicMenuCallbackDialog(int,
> int, char*)':
> ../../annotlib/BMmenu.c:804: error: cast from 'char*' to 'int' loses
> precision
> ../../annotlib/BMmenu.c: In function 'void TopicURLCallbackDialog(int,
> int, char*)':
> ../../annotlib/BMmenu.c:1079: error: cast from 'char*' to 'int' loses
> precision
> ../../annotlib/BMmenu.c:1141: warning: ignoring return value of 'char*
> getcwd(char*, size_t)', declared with attribute warn_unused_result
> ../../annotlib/BMmenu.c: In function 'void InitTopicURL()':
> ../../annotlib/BMmenu.c:1174: warning: ignoring return value of 'char*
> getcwd(char*, size_t)', declared with attribute warn_unused_result
> make[2]: *** [BMmenu.o] Error 1

OK, the first reason I didn't see this failure is because I don't enable
bookmarks

> I have a patch for this file (attached), when I try to recompile I now
> get

Attached is a slightly updated patch. The only difference with yours is
that the variables are declared as uintptr_t.

[snip]
> ../../annotlib/BMfile.c: In function 'Document redland_init(char*,
> char*, ThotBool)':
> ../../annotlib/BMfile.c:370: error:
> 'librdf_serializer_rdfxml_constructor' was not declared in this scope
> ../../annotlib/BMfile.c: In function 'ThotBool
> Model_queryExists(librdf_world*, librdf_model*, char*, char*, char*)':
> ../../annotlib/BMfile.c:707: error: 'librdf_heuristic_object_is_literal'
> was not declared in this scope
> ../../annotlib/BMfile.c: In function 'librdf_statement*
> Model_query(librdf_world*, librdf_model*, char*, char*, char*)':
> ../../annotlib/BMfile.c:749: error: 'librdf_heuristic_object_is_literal'
> was not declared in this scope
> ../../annotlib/BMfile.c: In function 'char*
> Model_getObjectAsString(librdf_world*, librdf_model*, librdf_node*,
> char*)':
> ../../annotlib/BMfile.c:869: warning: 'librdf_iterator_have_elements' is
> deprecated (declared at ../../../redland/librdf/rdf_iterator.h:73)
> ../../annotlib/BMfile.c:869: warning: 'librdf_iterator_have_elements' is
> deprecated (declared at ../../../redland/librdf/rdf_iterator.h:73)
> ../../annotlib/BMfile.c: At global scope:
> ../../annotlib/BMfile.c:736: warning: 'librdf_statement*
> Model_query(librdf_world*, librdf_model*, char*, char*, char*)' defined
> but not used

OK, this one is trickier. This file makes calls to to functions from the
redland library which are only supposed to be used internally. It worked
before because the flag -DLIBRDF_INTERNAL was passed at compile time.
But it makes it impossible to use a shared library. In addition, the
redland source in the tarball dates from early 2002, and some internal
functions have been removed since. So, in my case, I will simply avoid
building this part. If you want to use it, adding a

#define LIBRDF_INTERNAL

at the beginning of the file would probably do the trick.

HTH,

Regis