W3C home > Mailing lists > Public > www-amaya-dev@w3.org > April 2001

Re: 4.3.2 - minor configure and makefile tweaks...

From: Irene Vatton <Irene.Vatton@inrialpes.fr>
Date: Wed, 04 Apr 2001 16:26:18 +0200
To: mrsam@courier-mta.com
Cc: www-amaya-dev@w3.org, Irene.Vatton@inrialpes.fr
Message-Id: <20010404142619.1128029@maiana.inrialpes.fr>
> 
> In Amaya/configure.in:
> 
> ...
> 
> AC_ARG_WITH(more-shared, [  --without-graphic-libs    doesn't use provided
> libjpeg, libpng.])
> if test "$with_graphic-libs" = "no" ; then
> dnl
>     AC_MSG_CHECKING([for libjpeg version = 6b])
> 
> ...
> 
> Ummm... That ain't right.  This should probably read:
> 
> ...
> 
> AC_ARG_WITH(graphic-libs, [  --without-graphic-libs    doesn't use provided
> libjpeg, libpng.])
> if test "$withval" = "no" ; then
> dnl
>     AC_MSG_CHECKING([for libjpeg version = 6b])
> 
> ...
> 
> I patched it, ran it with this flag, it apparently worked:

Okay. I integrated your change.

> Additionally, according to autoconf documentation, $withval should really
> be tested inside a third argument to AC_ARG_WITH.  This will probably work
> correctly forever, but...
> 
> Also, for some of the subdirectories, Amaya/Makefile.in resets CFLAGS to
> -O, instead of propagating it down.  I'm not sure if there's a specific
> reason for this.  I've been applying the following patch since 4.1, and
> using -O2 with gcc.  I have not noticed any problems.

This is annoying for us, because we need to transmit some debug flags.
I just applied your patch to the building of tools, libjpeg, libpng, and zlib.
Thanks for your contribution
Received on Wednesday, 4 April 2001 10:22:18 UTC

This archive was generated by hypermail 2.3.1 : Tuesday, 6 January 2015 20:25:45 UTC