RE: Reviewing pull request for CfC

Thank you, Steve.

I found the following command to be useful, after running
git checkout accessible-name-terminology-sync
and using the git log command to obtain the identifier of the first revision in the change:

git diff –word-diff -U0 7c9573

This shows just the lines that changed (with inserted and deleted words marked) – no context lines.

From: Repsher, Stephen J [mailto:stephen.j.repsher@boeing.com]
Sent: Friday, September 29, 2017 11:03 AM
To: White, Jason J <jjwhite@ets.org>; Andrew Kirkpatrick <akirkpat@adobe.com>; WCAG <w3c-wai-gl@w3.org>
Subject: RE: Reviewing pull request for CfC


I have the Git command line tools installed. If there’s a branch for the pull request, I should be able to obtain the patch from it.
[Steve] At the bottom of the pull request on GitHub is where you can find the branch associated with the pull.  In this case the branch is “accessible-name-terminology-sync”.

Git can also be configured to show word-by-word diffs rather than line-by-line, a feature that I found especially useful in making final revisions to my Ph.d. thesis written in LaTeX.
[Steve] Yes, git can be configured to show a diff nearly any way you can configure the Linux diff command.  Unfortunately, the options on the GitHub web interface are very limited.

From: Andrew Kirkpatrick [mailto:akirkpat@adobe.com]
Sent: Friday, September 29, 2017 10:50 AM
To: White, Jason J <jjwhite@ets.org<mailto:jjwhite@ets.org>>; WCAG <w3c-wai-gl@w3.org<mailto:w3c-wai-gl@w3.org>>
Subject: Re: Reviewing pull request for CfC

Jason,
Github doesn’t make this too easy. Here’s what I’m seeing that might help:

The table rows reflect the line numbers that have changes. The rows that are highlighted are:
First file/table
231
470, 471
Next file/table
2, 8, 9, 10
Next file/table
1-9 (deletes whole file)
Last file/table
232

When I do a text search I can find the additions by searching for “+ “ in the browser. I can almost do the same for the deletions, but in some cases there isn’t a space after the “-“ that indicates that the markup will be removed, and searching for the dash without a space isn’t a helpful search.

I don’t see any good labels to otherwise search for. We should make a recommendation to GitHub – they have been quite responsive in the past.

Thanks,
AWK

Andrew Kirkpatrick
Group Product Manager, Accessibility
Adobe

akirkpat@adobe.com<mailto:akirkpat@adobe.com>
http://twitter.com/awkawk<https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Ftwitter.com%2Fawkawk&data=02%7C01%7Cjjwhite%40ets.org%7C490336416e644987d97308d5074b2aa5%7C0ba6e9b760b34fae92f37e6ddd9e9b65%7C0%7C0%7C636422941800251150&sdata=3gAcHfOn5OWHdXVmIRxdYZWqsUsK83vFhWyt6dqqWVQ%3D&reserved=0>

From: "White, Jason J" <jjwhite@ets.org<mailto:jjwhite@ets.org>>
Date: Friday, September 29, 2017 at 10:22
To: WCAG <w3c-wai-gl@w3.org<mailto:w3c-wai-gl@w3.org>>
Subject: Reviewing pull request for CfC
Resent-From: WCAG <w3c-wai-gl@w3.org<mailto:w3c-wai-gl@w3.org>>
Resent-Date: Friday, September 29, 2017 at 10:23

I’m having difficulty reviewing the tables on GitHub in which the source code is presented of the pull request currently under review in the CfC.

Is there a way to obtain a plain text diff patch of the change, or another textual format which would be easier to read and review?


________________________________

This e-mail and any files transmitted with it may contain privileged or confidential information. It is solely for use by the individual for whom it is intended, even if addressed incorrectly. If you received this e-mail in error, please notify the sender; do not disclose, copy, distribute, or take any action in reliance on the contents of this information; and delete it from your system. Any other use of this e-mail is prohibited.


Thank you for your compliance.

________________________________

________________________________

This e-mail and any files transmitted with it may contain privileged or confidential information. It is solely for use by the individual for whom it is intended, even if addressed incorrectly. If you received this e-mail in error, please notify the sender; do not disclose, copy, distribute, or take any action in reliance on the contents of this information; and delete it from your system. Any other use of this e-mail is prohibited.


Thank you for your compliance.

________________________________

________________________________

This e-mail and any files transmitted with it may contain privileged or confidential information. It is solely for use by the individual for whom it is intended, even if addressed incorrectly. If you received this e-mail in error, please notify the sender; do not disclose, copy, distribute, or take any action in reliance on the contents of this information; and delete it from your system. Any other use of this e-mail is prohibited.


Thank you for your compliance.

________________________________