- From: Adam Bergkvist <adam.bergkvist@ericsson.com>
- Date: Tue, 19 Jun 2012 16:04:25 +0200
- To: "Cullen Jennings (fluffy)" <fluffy@cisco.com>
- CC: Justin Uberti <juberti@google.com>, "public-webrtc@w3.org" <public-webrtc@w3.org>
On 2012-06-18 20:57, Cullen Jennings (fluffy) wrote: > > This seems like good proposal, one comment on a small detail. > > On Jun 15, 2012, at 1:28 PM, Justin Uberti wrote: > >> SessionDescriptionOptions.IncludeAudio = true/false // forces m=audio line to be included >> SessionDescriptionOptions.IncludeVideo = true/false // forces m=video line to be included >> SessionDescriptionOptions.UseVoiceActivityDetection = true/false // includes CN codecs if true > > I think these three should be constraints, not settings because a given browser may not support any of them. Shouldn't useVoiceActivityDetection be on addStream()-level? It seems to be a more appropriate place to do this since it's more codec setting/constraint rather than a setting on session-level. /Adam
Received on Tuesday, 19 June 2012 14:04:55 UTC