W3C home > Mailing lists > Public > public-webrtc@w3.org > August 2012

Re: CHANGE: [Bug 18486] New: Let RTCSessionDescription take a Dictionary parameter

From: Harald Alvestrand <harald@alvestrand.no>
Date: Mon, 27 Aug 2012 11:00:17 +0200
Message-ID: <503B3721.2020309@alvestrand.no>
To: Adam Bergkvist <adam.bergkvist@ericsson.com>
CC: "public-webrtc@w3.org" <public-webrtc@w3.org>
On 08/27/2012 10:33 AM, Adam Bergkvist wrote:
> On 2012-08-24 19:32, Harald Alvestrand wrote:
>> On 08/24/2012 05:51 PM, Randell Jesup wrote:
>>> On 8/24/2012 10:43 AM, Tommy Widenflycht (ᛏᚮᛘᛘᚤ) wrote:
>>>> It has been pointed out to me that the stringify algorithm is broken,
>>>> especially for RTCSessionDescription since the sdp member most 
>>>> certainly
>>>> contains newlines. Should had noticed that myself, doh.
>>>>
>>>> Also some clarification regarding exactly what the end result is 
>>>> need to
>>>> be put in the specification.
>>>> We had a discussion regarding if this was meant to be JSON or not.
>>>>
>>>> /Tommy
>>>>
>>>> On Wed, Aug 22, 2012 at 2:10 PM, Tommy Widenflycht (ᛏᚮᛘᛘᚤ)
>>>> <tommyw@google.com <mailto:tommyw@google.com>> wrote:
>>>>
>>>>      I'm fine both with removing the stringifier and letting it create
>>>>      "JS object strings" as long as everyone understands that it
>>>>      isn't necessarily JSON compatible.
>>>>
>>>>      JSON.stringify(object) != (string)object
>>>
>>> So, we have 3 options:
>>> 1) Use the current stringifier (with fixes for newlines, maybe quotes)
>>> 2) Move it to valid JSON (newlines, quotes, parens, ?)
>>> 3) drop the stringifier and use "JS object strings" (what's the impact
>>> of this?
>> If we drop the stringifier, I think the result of trying to interpret
>> the object as a string is "{ object object }", which is well defined,
>> but kind of useless.
>>
>> I wouldn't mind dropping it until we find a good reason to standardize
>> it; people who want a particular stringification can write their own
>> stringifiers.
>
> Blame me for the strange stringifier. I pushed an update but it didn't 
> make it into the August 16 draft.
>
> Tommy's proposal was to make RTCSessionDescription/RTPIceCandidate 
> work with JSON.stringify() so what we want is a serializer [1]. The 
> spec in github has this. We might want a stringifier as well that 
> gives us something else than the "[Object ...]", but I removed the 
> semi-JSON stringifier for now.
SGTM. Anyone who wants a stringifier can add it in their Javascript.
Received on Monday, 27 August 2012 09:00:52 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Monday, 27 August 2012 09:00:53 GMT