- From: Just a bot via GitHub <sysbot+gh@w3.org>
- Date: Wed, 05 Jul 2017 09:11:58 +0000
- To: public-webrtc-testsuite@w3.org
wpt-pr-bot has just labeled a pull request from soareschen for https://github.com/w3c/web-platform-tests as "wg-webrtc": == Rewrite tests for RTCConfiguration iceServers == The latest editor's draft have removed the `token` `credentialType` since 20170508. Instead a new `oath` `credentialType` is added. As a result, some of the existing tests for RTCPeerConnection-constructor is no longer valid. I have extracted the existing tests for iceServers from RTCPeerConnection-constructor.html and rewrite them in RTCConfiguration-iceServers.html. The rewrite includes coverage annotation with current spec, and test helper function to test the same configuration with `new RTCPeerConnection()` and `setConfiguration()`. The initial commit for this PR points to the tip of tree draft. The main difference is that `NotSupportedError` is thrown instead of `SyntaxError` when unknown URL scheme is provided. (w3c/webrtc-pc#1433). To make ease of the transition, I added a commit 0dc620f that revert the test back to the latest editor draft. Hopefully with this approach, this PR can be merged first without issue, and when new editor's draft is published, commit 0dc620f can be reverted so that the tests can be updated without too much effort. See https://github.com/w3c/web-platform-tests/pull/6468
Received on Wednesday, 5 July 2017 09:12:04 UTC