- From: henbos via GitHub <sysbot+gh@w3.org>
- Date: Fri, 11 Aug 2023 08:32:19 +0000
- To: public-webrtc-logs@w3.org
I like failing fast. I.e. I'd rather have `setCodecPreferences` or `direction` throw than `createOffer`. So I think `setCodecPreferences` with a `sendonly` codec but the transciever is `recvonly` should throw an exception. Likewise if you've configured `sendonly` codecs with a `sendonly` transceiver and you attempt to set the direction to `recvonly`, setting that attribute will throw the exception (yes setters can throw, we already do this e.g. if the transceiver is stopped). What if you want to change from `sendonly` codec+transceiver to `recvonly` codec+transceiver? It's a bit of an edge case, but you can still do that and avoid exception, you just have to make sure to set the direction to `inactive` as a middle step to prevent throwing. -- GitHub Notification of comment by henbos Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/2888#issuecomment-1674388178 using your GitHub account -- Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Friday, 11 August 2023 08:32:20 UTC