Re: [webrtc-pc] Missing url in RTCIceCandidateInit (#2795)

>  ... folks are using candidate.toJSON() ...

What's your source for this, and why would this group be larger than folks using JSON.stringify(candidate)?

I don't think there's a semantic difference, and if there is one, I wouldn't exploit it.

Since `relayProtocol` and `url` [are not implemented by anyone](https://wpt.fyi/results/webrtc/idlharness.https.window.html?label=experimental&label=master&aligned), folks expecting to see them will be disappointed.

Web compat here is that:
1. `JSON.stringify(candidate)` — only `candidate`, `sdpMid` and `sdpMLineIndex` appear
2. `new RTCIceCandidate(JSON.parse(JSON.stringify(candidate)))` — All members (except relayProtocol and url) are rehydrated from the candidate string

I claim there's no web compat problem here. The only concern might be people expecting relayProtocol and url to start showing up, but nothing in the spec supports such an assumption.

-- 
GitHub Notification of comment by jan-ivar
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/2795#issuecomment-1315900201 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Tuesday, 15 November 2022 21:43:25 UTC