- From: Andreas Pehrson via GitHub <sysbot+gh@w3.org>
- Date: Tue, 19 Nov 2019 16:26:53 +0000
- To: public-webrtc-logs@w3.org
I'm a bit torn about adding attributes this way because if one were to add support for all encoder capabilities we'd get a very large struct, without any apparent structure. Unfortunately there's precedence through the BitsPerSecond attributes. To be pragmatic and to set a precedence that hopefully avoids painting us too far into potential future corners, I suggest we change it to `audioBitrateControl` (or some such, bikeshedding on the name welcome), which can take the values `cbr` and `vbr`, at least. Do we need more? Likewise for video since we're adding the spec language for this anyway. I think this should use slots in the ctor algorithm like is done for the BitsPerSecond init dict attributes, because the start algorithm (where these attributes should be used to constrain the configuration of the recorder) doesn't have access to the init dict. We should probably say something on what is allowed if the UA for some reason does not support a given mode. -- GitHub Notification of comment by Pehrsons Please view or discuss this issue at https://github.com/w3c/mediacapture-record/pull/185#issuecomment-555589127 using your GitHub account
Received on Tuesday, 19 November 2019 16:26:55 UTC