W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > June 2019

Re: [webrtc-pc] {iceRestart: true} works poorly with negotiationneeded (#2167)

From: Jan-Ivar Bruaroey via GitHub <sysbot+gh@w3.org>
Date: Sat, 08 Jun 2019 21:25:53 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-500165346-1560029152-sysbot+gh@w3.org>
> What I dislike about the new API surface is that it seems like it's doing an imperative action
> ("RestartIce"), while what it's actually doing is (probably) triggering a negotiation request,
> which will just call back out to user code.

Arguably, when `negotiationneeded` is configured correctly, this method ***is*** the imperative action that triggers ICE to be restarted.

It will keep triggering the `negotiationneeded` event until an ICE-restarting negotiation has completed. I don't know what more we would expect an imperative `restartIce()` method to do.

Its predecessor never started negotiation:
```js
await createOffer({iceRestart: true}); // no-op alone
```

-- 
GitHub Notification of comment by jan-ivar
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/2167#issuecomment-500165346 using your GitHub account
Received on Saturday, 8 June 2019 21:25:54 UTC

This archive was generated by hypermail 2.3.1 : Saturday, 8 June 2019 21:25:54 UTC