W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > June 2019

Re: [webrtc-stats] Remove RTC[Audio/Video][Sender/Receiver]Stats.remoteSource (#399)

From: Jan-Ivar Bruaroey via GitHub <sysbot+gh@w3.org>
Date: Thu, 06 Jun 2019 18:46:48 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-499619604-1559846807-sysbot+gh@w3.org>
I agree with this. Removal also solves the ambiguity of its language: *"True if the source is remote, for instance if it is sourced from another host via an RTCPeerConnection"*

In the [forwarding case](https://webrtc.github.io/samples/src/content/peerconnection/multiple-relay/), where a track from one peer connection is feed into another, this would return `true`, confusing code relying on `remoteSource` to deduce whether it is sending or receiving.

> It is still needed for ye olde "track" stats though.

`"track"` stats in the spec are never remote.

Since I'm doing an audit of mandatory stats, I've taken the liberty of providing a PR. @henbos PTAL.

-- 
GitHub Notification of comment by jan-ivar
Please view or discuss this issue at https://github.com/w3c/webrtc-stats/issues/399#issuecomment-499619604 using your GitHub account
Received on Thursday, 6 June 2019 18:46:49 UTC

This archive was generated by hypermail 2.3.1 : Thursday, 6 June 2019 18:46:50 UTC