Re: [webrtc-pc] Handling of invalid values in RTCRtpSender.setParameters()

Based on the slide in https://www.w3.org/2011/04/webrtc/wiki/images/5/54/WebRTCWG-2018-05-22.pdf it seems the proposal is to:
- make `scaleResolutionDownBy` and `maxFramerate` unsigned
- check lower boundary on `maxFramerate` and `maxBitrate`
- check upper boundary on `scaleResolutionDownBy`
- check boundaries on `ptime`

To me it seems a bit hard to check the boundaries. At least for `maxBitrate` this can depend a lot on codec used and on content type (static vs quickly moving), and codec used can change e.g. due to an offer/answer exchange in the middle of a session (and content can also change).

My proposal would be to first do the changes of type to unsigned.

-- 
GitHub Notification of comment by stefhak
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/1834#issuecomment-408104056 using your GitHub account

Received on Thursday, 26 July 2018 13:50:16 UTC